Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs build is not tested #84

Open
JJ opened this issue Oct 26, 2020 · 10 comments
Open

Docs build is not tested #84

JJ opened this issue Oct 26, 2020 · 10 comments
Assignees

Comments

@JJ
Copy link

JJ commented Oct 26, 2020

In some cases and for some versions (probably not the last one), instead of using the default mustache template, it's using the default pod-to-html template, as shown here. Refs Raku/Documentable#142.
It does work correctly with the configuration indicated in the comments. Takes a long time, though.
The problem becomes now to integrate those tests as spec for this module.

@Altai-man
Copy link
Member

Hi. Can you please specify exact reproduce steps for this, what was expected and how it behaves instead?

@Altai-man Altai-man self-assigned this Oct 26, 2020
@JJ
Copy link
Author

JJ commented Oct 26, 2020

I'm trying to reproduce it. So far, it does not seem to happen with Pod::To::HTML 0.7.1 and Raku 2020.10

@JJ
Copy link
Author

JJ commented Oct 26, 2020

At any rate, we need to integrate any test for this module done in Documentable here; that should be spec for this module.

@JJ JJ changed the title Docs build is broken Docs build is not tested Oct 26, 2020
@JJ
Copy link
Author

JJ commented Oct 26, 2020

OK, it seems to work now with, if not the latest version of Pod::To::HTML, the next-to-last version. I'm testing for the last version anyway.

@JJ
Copy link
Author

JJ commented Oct 26, 2020

... but it's broken in 0.8:
Captura de pantalla de 2020-10-26 12-11-32
... it's missing title and the small style snip that's used by default.

@Altai-man
Copy link
Member

Can you post commands you are running, please?

@JJ
Copy link
Author

JJ commented Oct 26, 2020

  1. Fresh install of raku 2020.10
  2. Install Pod::To::HTML from source, zef install .
  3. Install documentable from zef, version 2.0.1
  4. documentable start -a -v --highlight

Title is missing from index.html and 404.html (as shown above). The <style> section (which, TBH, I'm not so totally sure about) is missing from all
Captura de pantalla de 2020-10-26 12-55-16

These are only the errors that pop up. The problem is that, again, it's not tested against its main use, so we don't know if there are any other errors somewhere.

@JJ
Copy link
Author

JJ commented Oct 26, 2020

BTW, it takes 976 seconds, which is roughly 30% more that it takes with version 0.7.1. It might still be a good idea to do a proper release of 0.7.1 after all.

@Altai-man
Copy link
Member

Thank you! I will look into it after $dayjob.

@Altai-man
Copy link
Member

BTW, it takes 976 seconds, which is roughly 30% more that it takes with version 0.7.1. It might still be a good idea to do a proper release of 0.7.1 after all

Can confirm this. I think we will have it faster than before with Cro::WebApp (once #82 is resolved).

Title is missing from index.html and 404.html

I had the same behavior with Pod::To::HTML 0.7.1. Glancing at the code yesterday I am not sure where the title for those pages was set at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants