Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 404 & 500 page #164

Open
coke opened this issue Feb 28, 2023 · 12 comments
Open

Create 404 & 500 page #164

coke opened this issue Feb 28, 2023 · 12 comments
Assignees
Labels
build Building the site UI CSS/HTML issues

Comments

@coke
Copy link
Contributor

coke commented Feb 28, 2023

perhaps using raku doc's 404 as a model, we need to add a 404 handler page instead of relying on the nginx handler.

Related to Raku/doc#4214

@coke coke added this to the 2023-Quarter 1 milestone Feb 28, 2023
@finanalyst
Copy link
Collaborator

@coke there is a 404.html that is generated and is in the root directory, but it is not being served by NGINX. So, the default NGINX 404 handler needs changing.

@coke coke self-assigned this Feb 28, 2023
@finanalyst
Copy link
Collaborator

Also look at new-raku 404

@coke
Copy link
Contributor Author

coke commented Feb 28, 2023

See #171

@Altai-man
Copy link
Member

There are templates for 404 and 500 errors fitting the design, please do use them: http://164.90.207.89:10010/baka

See https://github.com/Altai-man/docs.raku.org/blob/master/templates/404.crotmp and https://github.com/Altai-man/docs.raku.org/blob/master/templates/500.crotmp for templates.

@coke
Copy link
Contributor Author

coke commented Mar 1, 2023

The 404 page is created in the build and the website is now using it. Note that it seems to follow the text of the original site more than the update here. I have some edits for that in mind.

I can add the website rules for the 500 error once that page is generated during the build.

@coke coke added UI CSS/HTML issues build Building the site labels Mar 1, 2023
@coke coke changed the title Create 404 page Create 404 & 500 page Mar 1, 2023
coke added a commit that referenced this issue Mar 1, 2023
@finanalyst
Copy link
Collaborator

The 404 currently used on the site is generated from a .rakudoc file, so it can be consistently edited.
The 404/500 pages suggested by @Altai-man are crotmp templates. Like the index.html page, these could be just hacked into structure-source pages like index.rakdoc.

But note the text on Altai-man's page 'this error is already been reported' What does this mean. How is it reported?

@coke
Copy link
Contributor Author

coke commented Mar 1, 2023

Please see my suggested version in #178

@coke
Copy link
Contributor Author

coke commented Mar 1, 2023

But note the text on Altai-man's page 'this error is already been reported' What does this mean. How is it reported?

I assume "it's in the logs"; we should definitely be reporting out on the logs, or at least investigating occasionally. Odds of getting a 500 on the static site are slim, though.

@finanalyst
Copy link
Collaborator

What changes did you want?

@coke
Copy link
Contributor Author

coke commented Mar 1, 2023

What changes did you want?

The ones I submitted in the PR?

@finanalyst
Copy link
Collaborator

@coke I missed the PR request. Just approved.

@Altai-man
Copy link
Member

But note the text on Altai-man's page 'this error is already been reported' What does this mean. How is it reported?

The idea was that the engine will be smart enough to, on replying to a 404/500 request, report the error somewhere so that we could check what broke or what's the URL in question someone couldn't access, hence the line.

coke added a commit that referenced this issue Mar 1, 2023
@coke coke modified the milestones: 2023-Quarter 1, 2023-Quarter 2 Apr 1, 2023
@coke coke modified the milestones: 2023-Quarter 2, 2023-Quarter 3 Jul 12, 2023
@coke coke removed their assignment Aug 15, 2023
@coke coke modified the milestones: 2023-Quarter 3, 2023-Quarter 4 Oct 8, 2023
@coke coke removed this from the 2023-Quarter 4 milestone Mar 31, 2024
@coke coke added this to the 2024-Quarter-2 milestone Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Building the site UI CSS/HTML issues
Projects
None yet
Development

No branches or pull requests

3 participants