Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend range of values for display brightness setting #2101

Open
ia opened this issue Mar 6, 2025 · 4 comments
Open

Extend range of values for display brightness setting #2101

ia opened this issue Mar 6, 2025 · 4 comments
Assignees
Labels
Duplicate Already reported. Usability UX, Usability and/or Design.

Comments

@ia
Copy link
Collaborator

ia commented Mar 6, 2025

Describe the bug
Range of values for display brightness setting may be too short for some situations.

To Reproduce
Open OLED brightness in settings: it has values from 0/1 to 5 (from 0/1 to 100 with step 25 under the hood).

Expected behavior
Display brightness may have more wide range of values, i.e., from 1 to 10 (from 0/1 to 100 with step 10).

Details of your device:
Applicable to any supported device.

Additional context
I would like to fill this bug report to track further possible work & to track the feedback from other users. Considering how much IronOS users like to tweak their irons and customize every possible setting and button, I'm very surprised that no one didn't ask for this before. I've made a couple of test builds already, hacking around MIN / MAX / STEP brightness in configuration.h, and considering that users may have to work in different light conditions, I start to think that brightness should have a bit more wider range of values. It seems that from 1 to 10 with 10 step looks pretty reasonable, but at the same time it gives pretty distinguishable light for every step.

@Ralim & @discip, what do you think? Would you agree to accept this as new global defaults?

@ia ia added Enhancement New feature or additional function. Usability UX, Usability and/or Design. labels Mar 6, 2025
@ia ia assigned ia, Ralim and discip Mar 6, 2025
@discip
Copy link
Collaborator

discip commented Mar 6, 2025

@ia
This is funny — some time ago, there was a request to reduce the increments from 10 to 5 (see #1622). 🤣
So that's what I ended up with, and every one seemed to be happy.

Another helpful reference in this regard: #1087

@ia ia added Duplicate Already reported. and removed Enhancement New feature or additional function. labels Mar 7, 2025
@ia
Copy link
Collaborator Author

ia commented Mar 7, 2025

@discip, sorry for the false alarm. Very interesting discussions indeed. Well, I guess I just will be carry custom defines around my build myself then, because I really like extended range more. :)

@discip
Copy link
Collaborator

discip commented Mar 7, 2025

Don't get me wrong—this isn't set in stone! 😊
If people need finer increments, then that's the way to go.
I personally use all my devices on the lowest setting anyway.
Maybe @Ralim has a definitive opinion on this?

@Ralim
Copy link
Owner

Ralim commented Mar 10, 2025

Err I dont have strong feelings.
@ia I'm curious why you use the extra steps, how often are you adjusting this? 🤣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate Already reported. Usability UX, Usability and/or Design.
Projects
None yet
Development

No branches or pull requests

3 participants