Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLCD refactoring #150

Open
GoogleCodeExporter opened this issue Mar 3, 2016 · 3 comments
Open

GLCD refactoring #150

GoogleCodeExporter opened this issue Mar 3, 2016 · 3 comments

Comments

@GoogleCodeExporter
Copy link

There are currently at least 3 GLCD libraries, but each is using its own way to 
deal with fonts & pixel-based drawings, and API isn't normalized.

TODO (unordered):

- font libs must be named the same (glcd_font_WxH or glcd_font_HxW)
- glcd_nokia_3310 needs lcd_write_pixel() implementation
- check memory/stack usage during refactoring


Original issue reported on code.google.com by [email protected] on 21 Feb 2011 at 8:39

@GoogleCodeExporter
Copy link
Author

Code involved in this refactoring will stay in project/glcd_cache so current 
release isn't disturb.

Original comment by [email protected] on 21 Feb 2011 at 8:40

@GoogleCodeExporter
Copy link
Author

There are two main ways to use GLCD:
  - char-based stuff
  - pixel-based stuff

I suggest every char-based proc/func go to glcd_font.jal. All pixel-based 
proc/func could remain in glcd_common.jal (maybe renamed).

Ex: lcd_set_cursor(row,col) is char-based, because args correspond to row/col 
in a grid defined by font width * height. It's not named appropriately. And 
maybe it could go to glcd_font.jal

Ex2: in nokia 3310 lib, there's a lcd_gotoxy(x,y). This time pixel based. Maybe 
this procedure could be part of standard API, meaning every GLCD lib should 
implement it. 

Original comment by [email protected] on 21 Feb 2011 at 9:25

@GoogleCodeExporter
Copy link
Author

I'd like to get this fixed too.  The jallib-pack-bee download doesn't even have 
the nokia library.  How are people using the Nokia with JAL?  The libs I'm 
using aren't in the jallib pack.

Original comment by [email protected] on 12 Dec 2012 at 10:33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant