Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotfiles/Configs traversal #15

Open
RaphGL opened this issue Mar 27, 2023 · 0 comments
Open

Fix dotfiles/Configs traversal #15

RaphGL opened this issue Mar 27, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@RaphGL
Copy link
Owner

RaphGL commented Mar 27, 2023

The DotfileGroup::map is a function that applies another function to every file in a group's directory. But certain directories are special and need to avoid being symlinked, Right now tuckr only is aware of XDG dirs therefore it's faulty on windows and macos, it won't be able to validate symlinks in directories such as AppData/Roaming.

The solution is to either get all directories from the dirs library and try to match to it somehow (a bit more involved) or use WalkDir and symlink every single file and directory of a certain group.

This issue can be fixed by adding shallow symlinking

@RaphGL RaphGL added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 27, 2023
@RaphGL RaphGL removed help wanted Extra attention is needed good first issue Good for newcomers labels Jun 17, 2023
@RaphGL RaphGL changed the title Improve symlinking with group_dir_map Improve dotfiles/Configs traversal Jun 17, 2023
@RaphGL RaphGL changed the title Improve dotfiles/Configs traversal Fix dotfiles/Configs traversal Jun 17, 2023
@RaphGL RaphGL added the bug Something isn't working label Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant