857-fix-rubocop (#584)

## Status

- Closes
RaspberryPiFoundation/digital-editor-issues#857

## What's changed?

- Updates rubocop and associated plugins
- Fixes rubocop syntax
- Fixes lint issues

## Steps to perform after deploying to production

N/A

Author: danhalson

.rubocop.yml

@@ -1,7 +1,12 @@
 ---
 require:
   - rubocop-graphql
+plugins:
+  - rubocop-rails
   - rubocop-capybara
+  - rubocop-performance
+  - rubocop-rspec_rails
+  - rubocop-factory_bot
 inherit_from:
   - https://raspberrypifoundation.github.io/digital-engineering/configs/rubocop-base.yml
   - https://raspberrypifoundation.github.io/digital-engineering/configs/rubocop-rails.yml
@@ -28,11 +33,17 @@ RSpec/DescribeClass:
     - "spec/graphql/mutations/**"
 
 RSpec/MultipleMemoizedHelpers:
-  Max: 8
+  Max: 15
 
 RSpec/ExampleLength:
   Enabled: false
 
+RSpec/MultipleExpectations:
+  Enabled: false
+
+RSpec/IndexedLet:
+  Enabled: false
+
 Metrics/BlockLength:
   Enabled: false
 
@@ -45,3 +56,9 @@ Layout/LineLength:
 Naming/VariableNumber:
   EnforcedStyle: snake_case
   AllowedIdentifiers: sha256, X-Hub-Signature-256
+
+Style/SafeNavigationChainLength:
+  Enabled: false
+
+Rails/EnvLocal:
+  Enabled: false

Gemfile

@@ -50,9 +50,13 @@ group :development, :test do
   gem 'rspec_junit_formatter'
   gem 'rspec-rails'
   gem 'rubocop', require: false
+  gem 'rubocop-capybara', require: false
+  gem 'rubocop-factory_bot', require: false
   gem 'rubocop-graphql', require: false
+  gem 'rubocop-performance', require: false
   gem 'rubocop-rails', require: false
   gem 'rubocop-rspec', require: false
+  gem 'rubocop-rspec_rails', require: false
   gem 'simplecov', require: false
 end
 

Gemfile.lock

@@ -98,7 +98,7 @@ GEM
     administrate-field-active_storage (1.0.1)
       administrate (>= 0.2.2)
       rails (>= 7.0)
-    ast (2.4.2)
+    ast (2.4.3)
     awesome_print (1.9.2)
     aws-eventstream (1.2.0)
     aws-partitions (1.718.0)
@@ -116,8 +116,8 @@ GEM
       aws-sigv4 (~> 1.4)
     aws-sigv4 (1.5.2)
       aws-eventstream (~> 1, >= 1.0.2)
-    base64 (0.2.0)
-    bigdecimal (3.1.8)
+    base64 (0.3.0)
+    bigdecimal (3.2.2)
     bootsnap (1.16.0)
       msgpack (~> 1.2)
     builder (3.3.0)
@@ -138,8 +138,8 @@ GEM
     choice (0.2.0)
     climate_control (1.2.0)
     coderay (1.1.3)
-    concurrent-ruby (1.3.3)
-    connection_pool (2.4.1)
+    concurrent-ruby (1.3.5)
+    connection_pool (2.5.3)
     countries (5.7.1)
       unaccent (~> 0.3)
     crack (0.4.5)
@@ -159,7 +159,7 @@ GEM
     dotenv-rails (2.8.1)
       dotenv (= 2.8.1)
       railties (>= 3.2)
-    drb (2.2.1)
+    drb (2.2.3)
     email_validator (2.2.4)
       activemodel
     erubi (1.13.0)
@@ -202,7 +202,7 @@ GEM
       graphql
     hashdiff (1.0.1)
     hashie (5.0.0)
-    i18n (1.14.5)
+    i18n (1.14.7)
       concurrent-ruby (~> 1.0)
     image_processing (1.12.2)
       mini_magick (>= 4.9.5, < 5)
@@ -222,7 +222,7 @@ GEM
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
       thor (>= 0.14, < 2.0)
-    json (2.6.3)
+    json (2.13.2)
     jwt (2.2.3)
     kaminari (1.2.2)
       activesupport (>= 4.1.0)
@@ -236,7 +236,8 @@ GEM
       activerecord
       kaminari-core (= 1.2.2)
     kaminari-core (1.2.2)
-    language_server-protocol (3.17.0.3)
+    language_server-protocol (3.17.0.5)
+    lint_roller (1.1.0)
     logger (1.6.0)
     loofah (2.22.0)
       crass (~> 1.0.2)
@@ -251,10 +252,10 @@ GEM
     method_source (1.0.0)
     mini_magick (4.12.0)
     mini_mime (1.1.2)
-    minitest (5.23.1)
+    minitest (5.25.5)
     msgpack (1.6.0)
     multi_xml (0.6.0)
-    mutex_m (0.2.0)
+    mutex_m (0.3.0)
     net-imap (0.4.12)
       date
       net-protocol
@@ -295,9 +296,10 @@ GEM
     paper_trail (15.1.0)
       activerecord (>= 6.1)
       request_store (~> 1.4)
-    parallel (1.22.1)
-    parser (3.2.1.0)
+    parallel (1.27.0)
+    parser (3.3.9.0)
       ast (~> 2.4.1)
+      racc
     pg (1.4.6)
     postmark (1.25.0)
       json
@@ -317,8 +319,8 @@ GEM
     puma (6.4.2)
       nio4r (~> 2.0)
     raabro (1.4.0)
-    racc (1.8.0)
-    rack (2.2.9)
+    racc (1.8.1)
+    rack (2.2.17)
     rack-cors (2.0.0)
       rack (>= 2.0.0)
     rack-protection (3.2.0)
@@ -371,13 +373,12 @@ GEM
       logger
     rdoc (6.7.0)
       psych (>= 4.0.0)
-    regexp_parser (2.7.0)
+    regexp_parser (2.11.2)
     reline (0.5.9)
       io-console (~> 0.5)
     request_store (1.7.0)
       rack (>= 1.4)
-    rexml (3.3.0)
-      strscan
+    rexml (3.4.1)
     rspec (3.12.0)
       rspec-core (~> 3.12.0)
       rspec-expectations (~> 3.12.0)
@@ -401,29 +402,44 @@ GEM
     rspec-support (3.12.0)
     rspec_junit_formatter (0.6.0)
       rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (1.47.0)
+    rubocop (1.74.0)
       json (~> 2.3)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
-      parser (>= 3.2.0.0)
+      parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
-      regexp_parser (>= 1.8, < 3.0)
-      rexml (>= 3.2.5, < 4.0)
-      rubocop-ast (>= 1.26.0, < 2.0)
+      regexp_parser (>= 2.9.3, < 3.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 2.4.0, < 3.0)
-    rubocop-ast (1.27.0)
-      parser (>= 3.2.1.0)
-    rubocop-capybara (2.17.1)
-      rubocop (~> 1.41)
+      unicode-display_width (>= 2.4.0, < 4.0)
+    rubocop-ast (1.42.0)
+      parser (>= 3.3.7.2)
+    rubocop-capybara (2.22.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-factory_bot (2.27.1)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
     rubocop-graphql (1.0.0)
       rubocop (>= 0.87, < 2)
-    rubocop-rails (2.18.0)
+    rubocop-performance (1.24.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rails (2.30.3)
       activesupport (>= 4.2.0)
+      lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.33.0, < 2.0)
-    rubocop-rspec (2.18.1)
-      rubocop (~> 1.33)
-      rubocop-capybara (~> 2.17)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rspec (3.6.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+    rubocop-rspec_rails (2.31.0)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-rspec (~> 3.5)
     ruby-graphviz (1.2.5)
       rexml
     ruby-lsp (0.17.7)
@@ -435,7 +451,7 @@ GEM
       ruby-lsp (>= 0.17.2, < 0.18.0)
     ruby-lsp-rspec (0.1.12)
       ruby-lsp (~> 0.17.0)
-    ruby-progressbar (1.11.0)
+    ruby-progressbar (1.13.0)
     ruby-vips (2.2.0)
       ffi (~> 1.12)
     ruby2_keywords (0.0.5)
@@ -482,7 +498,6 @@ GEM
       activesupport (>= 5.2)
       sprockets (>= 3.0.0)
     stringio (3.1.1)
-    strscan (3.1.0)
     thor (1.3.1)
     tilt (2.3.0)
     time (0.3.0)
@@ -491,7 +506,9 @@ GEM
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
     unaccent (0.4.0)
-    unicode-display_width (2.4.2)
+    unicode-display_width (3.1.5)
+      unicode-emoji (~> 4.0, >= 4.0.4)
+    unicode-emoji (4.0.4)
     uniform_notifier (1.16.0)
     uri (0.13.0)
     version_gem (1.1.3)
@@ -563,9 +580,13 @@ DEPENDENCIES
   rspec-rails
   rspec_junit_formatter
   rubocop
+  rubocop-capybara
+  rubocop-factory_bot
   rubocop-graphql
+  rubocop-performance
   rubocop-rails
   rubocop-rspec
+  rubocop-rspec_rails
   ruby-lsp (~> 0.17.7)
   ruby-lsp-rails
   ruby-lsp-rspec

app/controllers/test_utilities_controller.rb

@@ -7,23 +7,10 @@ class TestUtilitiesController < ApplicationController
   Rails.application.load_tasks if Rake::Task.tasks.empty?
 
   def reseed
-    # rubocop:disable Rails/Output
-    pp 'api_key_valid?', api_key_valid?
-    pp 'api_key_present?', ENV['RESEED_API_KEY'].present?
-    pp 'api_key_correct?', request.headers['X-RESEED-API-KEY'] == ENV['RESEED_API_KEY']
-    pp 'host_allowed?', host_allowed?
-    pp 'host', request.host
-    pp 'reseed_allowed?', reseed_allowed?
-
     if reseed_allowed?
-      pp 'reseed was allowed'
-      pp 'destroying seeds...'
       Rake::Task['test_seeds:destroy'].execute
-      pp 'creating seeds...'
       Rake::Task['test_seeds:create'].execute
-      pp 'success!'
       render json: { message: 'Database reseeded successfully.' }, status: :ok
-      # rubocop:enable Rails/Output
     else
       head :not_found
     end

app/models/role.rb

@@ -3,7 +3,7 @@
 class Role < ApplicationRecord
   belongs_to :school
 
-  enum :role, %i[student teacher owner]
+  enum :role, { student: 0, teacher: 1, owner: 2 }
 
   validates :user_id, presence: true
   validates :role, presence: true, uniqueness: { scope: %i[school_id user_id] }

app/models/school.rb

@@ -9,7 +9,7 @@ class School < ApplicationRecord
 
   VALID_URL_REGEX = %r{\A(?:https?://)?(?:www.)?[a-z0-9]+([-.]{1}[a-z0-9]+)*\.[a-z]{2,63}(\.[a-z]{2,63})*(/.*)?\z}ix
 
-  enum :user_origin, %i[for_education experience_cs], default: :for_education, validate: true
+  enum :user_origin, { for_education: 0, experience_cs: 1 }, default: :for_education, validate: true
 
   validates :name, presence: true
   validates :website, presence: true, format: { with: VALID_URL_REGEX, message: I18n.t('validations.school.website') }

config/initializers/content_security_policy.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide content security policy.

config/initializers/inflections.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Add new inflection rules using the following format. Inflections

config/initializers/permissions_policy.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Be sure to restart your server when you modify this file.
 
 # Define an application-wide HTTP permissions policy. For further

lib/concepts/project/operations/update.rb

@@ -75,7 +75,7 @@ def update_component_attributes(response, update_hash)
       end
 
       def overwrite_component_attributes(response, component_params)
-        component = response[:project].components.select { |c| c.id == component_params[:id] }.first
+        component = response[:project].components.find { |c| c.id == component_params[:id] }
         component.assign_attributes(component_params)
       end