Make updating public projects specs more realistic

The immediate use case for `Api::PublicProjectsController#update` is for
experience-cs admin users to change the name of a public project. Since
experience-cs only deals with Scratch projects, it makes sense to use
projects of this type in the specs. However, since we're using
`ProjectLoader` to find the project and the default scope is still in
place to hide Scratch projects, we need to make use of the
`ProjectScoping` concern to use the `project_type` param to set
`Current.project_scope` to include Scratch projects.

Author: floehopper

spec/features/public_project/updating_a_public_project_spec.rb

@@ -4,7 +4,7 @@
 
 RSpec.describe 'Updating a public project', type: :request do
   let(:creator) { build(:user) }
-  let(:project) { create(:project, locale: 'en') }
+  let(:project) { create(:project, locale: 'en', project_type: Project::Types::SCRATCH) }
   let(:headers) { { Authorization: UserProfileMock::TOKEN } }
   let(:params) { { project: { name: 'New name' } } }
 
@@ -13,29 +13,29 @@
   end
 
   it 'responds 200 OK' do
-    put("/api/public_projects/#{project.identifier}", headers:, params:)
+    put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params:)
     expect(response).to have_http_status(:success)
   end
 
   it 'responds with the project JSON' do
-    put("/api/public_projects/#{project.identifier}", headers:, params:)
+    put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params:)
     data = JSON.parse(response.body, symbolize_names: true)
 
     expect(data).to include(name: 'New name')
   end
 
   it 'responds 400 Bad Request when params are malformed' do
-    put("/api/public_projects/#{project.identifier}", headers:, params: {})
+    put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params: {})
     expect(response).to have_http_status(:bad_request)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
-    put("/api/public_projects/#{project.identifier}", params:)
+    put("/api/public_projects/#{project.identifier}?project_type=scratch", params:)
     expect(response).to have_http_status(:unauthorized)
   end
 
   it 'responds 404 Not Found when project is not found' do
-    put('/api/public_projects/another-identifier', headers:, params:)
+    put('/api/public_projects/another-identifier?project_type=scratch', headers:, params:)
     expect(response).to have_http_status(:not_found)
   end
 end

spec/requests/public_projects/update_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe 'Update public project requests' do
   let(:locale) { 'fr' }
   let(:project_loader) { instance_double(ProjectLoader) }
-  let(:project) { create(:project, locale: 'en') }
+  let(:project) { create(:project, locale: 'en', project_type: Project::Types::SCRATCH) }
   let(:creator) { build(:user) }
   let(:params) { { project: { name: 'New name' } } }
 
@@ -25,19 +25,19 @@
       end
 
       it 'builds ProjectLoader with identifier & locale' do
-        put("/api/public_projects/#{project.identifier}?locale=#{locale}", headers:, params:)
+        put("/api/public_projects/#{project.identifier}?project_type=scratch&locale=#{locale}", headers:, params:)
 
         expect(ProjectLoader).to have_received(:new).with(project.identifier, [locale])
       end
 
       it 'uses ProjectLoader#load to find the project based on identifier & locale' do
-        put("/api/public_projects/#{project.identifier}?locale=#{locale}", headers:, params:)
+        put("/api/public_projects/#{project.identifier}?project_type=scratch&locale=#{locale}", headers:, params:)
 
         expect(project_loader).to have_received(:load)
       end
 
       it 'returns success' do
-        put("/api/public_projects/#{project.identifier}", headers:, params:)
+        put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params:)
 
         expect(response).to have_http_status(:success)
       end
@@ -53,7 +53,7 @@
       end
 
       it 'returns error' do
-        put("/api/public_projects/#{project.identifier}", headers:, params:)
+        put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params:)
 
         expect(response).to have_http_status(:unprocessable_entity)
       end
@@ -62,7 +62,7 @@
 
   context 'when no token is given' do
     it 'returns unauthorized' do
-      put("/api/public_projects/#{project.identifier}", headers:, params:)
+      put("/api/public_projects/#{project.identifier}?project_type=scratch", headers:, params:)
 
       expect(response).to have_http_status(:unauthorized)
     end