Make destroying public projects specs more realistic

The immediate use case for `Api::PublicProjectsController#destroy` is
for experience-cs admin users to destroy a public project.  Since
experience-cs only deals with Scratch projects, it makes sense to use
projects of this type in the specs. However, since we're using
`ProjectLoader` to find the project and the default scope is still in
place to hide Scratch projects, we need to make use of the
`ProjectScoping` concern to use the `project_type` param to set
`Current.project_scope` to include Scratch projects.

Author: floehopper

spec/features/public_project/destroying_a_public_project_spec.rb

@@ -4,39 +4,39 @@
 
 RSpec.describe 'Destroying a public project', type: :request do
   let(:destroyer) { build(:experience_cs_admin_user) }
-  let(:project) { create(:project, locale: 'en') }
+  let(:project) { create(:project, locale: 'en', project_type: Project::Types::SCRATCH) }
   let(:headers) { { Authorization: UserProfileMock::TOKEN } }
 
   before do
     authenticated_in_hydra_as(destroyer)
   end
 
   it 'responds 200 OK' do
-    delete("/api/public_projects/#{project.identifier}", headers:)
+    delete("/api/public_projects/#{project.identifier}?project_type=scratch", headers:)
     expect(response).to have_http_status(:success)
   end
 
   it 'deletes the project' do
-    delete("/api/public_projects/#{project.identifier}", headers:)
+    delete("/api/public_projects/#{project.identifier}?project_type=scratch", headers:)
     expect(Project).not_to exist(identifier: project.identifier)
   end
 
   it 'responds 401 Unauthorized when no token is given' do
-    delete("/api/public_projects/#{project.identifier}")
+    delete("/api/public_projects/#{project.identifier}?project_type=scratch")
     expect(response).to have_http_status(:unauthorized)
   end
 
   context 'when destroyer is not an experience-cs admin' do
     let(:destroyer) { build(:user) }
 
     it 'responds 403 Forbidden' do
-      delete("/api/public_projects/#{project.identifier}", headers:)
+      delete("/api/public_projects/#{project.identifier}?project_type=scratch", headers:)
       expect(response).to have_http_status(:forbidden)
     end
   end
 
   it 'responds 404 Not Found when project is not found' do
-    delete('/api/public_projects/another-identifier', headers:)
+    delete('/api/public_projects/another-identifier?project_type=scratch', headers:)
     expect(response).to have_http_status(:not_found)
   end
 end

spec/requests/public_projects/destroy_spec.rb

@@ -5,7 +5,7 @@
 RSpec.describe 'Destroy public project requests' do
   let(:locale) { 'fr' }
   let(:project_loader) { instance_double(ProjectLoader) }
-  let(:project) { create(:project, locale: 'en') }
+  let(:project) { create(:project, locale: 'en', project_type: Project::Types::SCRATCH) }
   let(:destroyer) { build(:experience_cs_admin_user) }
 
   context 'when auth is correct' do
@@ -24,19 +24,19 @@
       end
 
       it 'builds ProjectLoader with identifier & locale' do
-        delete("/api/public_projects/#{project.identifier}?locale=#{locale}", headers:)
+        delete("/api/public_projects/#{project.identifier}?project_type=scratch&locale=#{locale}", headers:)
 
         expect(ProjectLoader).to have_received(:new).with(project.identifier, [locale])
       end
 
       it 'uses ProjectLoader#load to find the project based on identifier & locale' do
-        delete("/api/public_projects/#{project.identifier}?locale=#{locale}", headers:)
+        delete("/api/public_projects/#{project.identifier}?project_type=scratch&locale=#{locale}", headers:)
 
         expect(project_loader).to have_received(:load)
       end
 
       it 'returns success' do
-        delete("/api/public_projects/#{project.identifier}", headers:)
+        delete("/api/public_projects/#{project.identifier}?project_type=scratch", headers:)
 
         expect(response).to have_http_status(:success)
       end
@@ -50,7 +50,7 @@
       end
 
       it 'returns error' do
-        delete("/api/public_projects/#{project.identifier}", headers:)
+        delete("/api/public_projects/#{project.identifier}?project_type=scratch", headers:)
 
         expect(response).to have_http_status(:unprocessable_entity)
       end
@@ -59,7 +59,7 @@
 
   context 'when no token is given' do
     it 'returns unauthorized' do
-      delete("/api/public_projects/#{project.identifier}")
+      delete("/api/public_projects/#{project.identifier}?project_type=scratch")
 
       expect(response).to have_http_status(:unauthorized)
     end