-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade snarkjs to >0.6.11 #8
Comments
Thanks a lot. Yes, we should update after the fix:) |
Hey @mhchia , would one need to recompile/ redeploy all Verifier contracts due to this bug or is it further down the line? |
@themandalore I'm not sure about this, and I would also like to know the answer too 😃 |
Reopened to remind us that our dependency
An issue has been opened in
|
@themandalore In general I would say yes, you should update snarkjs and generate contracts with new snarkjs version. Though I don't think there are bugs in big and well audited projects, as it's common practice to do range/field checks on public inputs. |
What's wrong?
iden3/snarkjs#358 suggested a vulnerability of the groth16 verifier in the latest snarkjs (v0.6.11). A fix iden3/snarkjs#359 was proposed but has yet to be merged. The issue is not related to circom so it's safe to stay as is, as discussed with @curryrasul offline.
How to fix it?
Upgrade snarkjs to the latest version as long as the fix is released.
The text was updated successfully, but these errors were encountered: