Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade snarkjs to >0.6.11 #8

Open
mhchia opened this issue May 24, 2023 · 5 comments · Fixed by #10
Open

Upgrade snarkjs to >0.6.11 #8

mhchia opened this issue May 24, 2023 · 5 comments · Fixed by #10

Comments

@mhchia
Copy link
Member

mhchia commented May 24, 2023

What's wrong?

iden3/snarkjs#358 suggested a vulnerability of the groth16 verifier in the latest snarkjs (v0.6.11). A fix iden3/snarkjs#359 was proposed but has yet to be merged. The issue is not related to circom so it's safe to stay as is, as discussed with @curryrasul offline.

How to fix it?

Upgrade snarkjs to the latest version as long as the fix is released.

@curryrasul
Copy link
Contributor

Thanks a lot. Yes, we should update after the fix:)

mhchia added a commit that referenced this issue May 26, 2023
@themandalore
Copy link

Hey @mhchia , would one need to recompile/ redeploy all Verifier contracts due to this bug or is it further down the line?

@mhchia
Copy link
Member Author

mhchia commented Jun 15, 2023

@themandalore I'm not sure about this, and I would also like to know the answer too 😃

@mhchia
Copy link
Member Author

mhchia commented Jun 17, 2023

Reopened to remind us that our dependency circom_tester stills has this issue and hasn't fixed it. We should upgrade circom_tester as long as it upgrades snarkjs to >=0.7.0.

  1. Our circom_tester uses snarkjs==0.5.0
    "version": "0.5.0",

An issue has been opened in circom_tester too (iden3/circom_tester#16).

  1. It seems like it won't be fixed soon in circom_teser, and we only use it for testing, so we decided to reopen this issue and dismiss the alert from dependabot.

@mhchia mhchia reopened this Jun 17, 2023
@curryrasul
Copy link
Contributor

Hey @mhchia , would one need to recompile/ redeploy all Verifier contracts due to this bug or is it further down the line?

@themandalore In general I would say yes, you should update snarkjs and generate contracts with new snarkjs version. Though I don't think there are bugs in big and well audited projects, as it's common practice to do range/field checks on public inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants