This repository has been archived by the owner on Jun 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 143
Virtual-DOM and DOM-Delegator implicit peer dependency #122
Labels
Comments
I'm not sure what other requirements there are to upgrade |
@kumavis just published mercury@13 to fix this. I dont really know how to fix this peer dependency. |
I believe the open issue is that there is an implicit peer dependency where dom-delegator and virtual-dom need to be sharing a reference to the same ev-store. if they each got their own copy then it won't work. |
seems like vdom should supply its ev-store obj and dom-delegator should take it in right now its just magic that they end up with the same thing |
@kumavis 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Discovered this when using a later version of virtual-dom that uses ev-store instead of data-set. dom-delegator expects data-set. Ideally this would be decoupled instead of just moving to ev-store.
The text was updated successfully, but these errors were encountered: