Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single article page #33
Single article page #33
Changes from 10 commits
ae43512
c8a8449
d6c5bed
673ef61
cf1fbd5
e99f3cf
a50ccd0
97e5fd0
e1472bb
11e3702
7a2a859
49d0b4e
ac0e7c1
0153340
58f8fef
61ce65b
119ff3a
e6111f4
89e49d3
036cde6
d4ff5e9
bf777eb
98d7a9a
bf7101c
7fbbd40
e7f3d94
54e906d
4706083
24078e7
9825673
ae9f118
669b57d
e231e91
a39ec8b
ecb6f98
221a0ca
0958a68
f58f631
288bda8
3d470e7
78dc64d
2850b90
5614984
04f5484
54a4b5a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending on where the blog is coming from you probably don't want to do it this way because random letters will be cut off. in wordpress there is an 'excerpt' on the object that you can use
i see its coming from the translation files, actually the right way to do this is to add an "excerpt" field as well so that each excerpt is customized. cutting off in the middle of the word at a random character is a bad user experience
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we didn't start using WordPress yet.... but definitely I will check it out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
didn't get the name of the src
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is a place holder from bootstrap i changed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
px to rem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
px to rem
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still px