Feature map #17
Merged
Feature map #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for choose-wisely ready! 🔨 Explore the source changes: 9729bbf 🔍 Inspect the deploy log: https://app.netlify.com/sites/choose-wisely/deploys/611eaafee00b9200087d3672 😎 Browse the preview: https://deploy-preview-17--choose-wisely.netlify.app/ |
Ammar-64
requested changes
Aug 16, 2021
|
LGTM but I can't approve it now because it has changes from the other branch which will cause a conflict later, to solve it we either have to wait until the other one is merged or you can create another branch from dev, include only the map changes in it and open a new pr |
|
Thanks for the review, I'll wait until the other PR is merged and be careful next time to work on one branch per PR. |
|
@Dkay-code there are some conflicts need to be solved here before merging |
|
PTAL |
khadijahawa
approved these changes
Aug 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close issue #8 The map section is finished including a map with the number of universities by province.
A test folder was added to src and a snapshot test has been created under the name 'Map.test.js' for this section.