Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Kotlin version to use Duration? #252

Open
derektom14 opened this issue Apr 21, 2023 · 0 comments
Open

Update Kotlin version to use Duration? #252

derektom14 opened this issue Apr 21, 2023 · 0 comments

Comments

@derektom14
Copy link

Kotlin has a Duration type that would be useful to include for the various time-based Rx operators. (For example, using single.timeout(5.seconds) instead of single.timeout(5, TimeUnit.SECONDS).) However, this version of Duration was not finalized until 1.6 to be based on Long. RxKotlin is currently on Kotlin 1.4, so Duration is instead entirely different, using a Double instead. Can we increase the Kotlin version to 1.6 or further so that Duration is properly supported?

I can add the extension methods myself, I just need to first clear that the repo owners would be alright with increasing the Kotlin version as well, or else it won't be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant