Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to get extended acl? #74

Open
lordlala opened this issue Oct 14, 2015 · 20 comments
Open

Able to get extended acl? #74

lordlala opened this issue Oct 14, 2015 · 20 comments

Comments

@lordlala
Copy link

Hi. On the old java file manager you could manage the extended acl's or whatever. Is this possible or going to be possible with filemin?

@Real-Gecko
Copy link
Owner

I did not check exact Java FM ACL.
Can you describe what exactly you want to get?

@lordlala
Copy link
Author

Sorry for the delay.

In the java file browser, there is a button labeled "ACL" which allows you to manipulate the extended ACL properties of a file or folder. See attached image.
aclexample

@lordlala
Copy link
Author

Also, maybe I am doing something wrong or it just isn't designed to do this, but when I select a folder and click on the settings icon (chmod selected), it does not pull in the current permissions. Same with the chown button. Is this by design? I would like to be able to see what the current permission are, before making changes, so it would be helpful if it pre-filled the window with the current info. I hope that makes sense.

@Real-Gecko
Copy link
Owner

I don't see any unusal on screenshot that's not implemented in current version of Filemin. Maybe it is something in dropdown menu?
And yes, ops like "chmod" or "chown" are multientry, that means you can select ten folders and twenty files and chmod/chown them in one go. However in such a scenario it is impossible to get current permissions/owner cause it may vary across all selected items. This issue will be resolved after I implement context menu, allowing singular entry actions.

@Real-Gecko
Copy link
Owner

Closing due to no activity.

@dv-anomaly
Copy link

dv-anomaly commented May 24, 2017

ACL lets you set permissions on a per user / group basis not just the owner/group/other of a directory or file. https://help.ubuntu.com/community/FilePermissionsACLs Filemin does not seem to have this functionality?

For example I have a directory on my NAS with the following ACLs:

dh4@dh4-nas:~$ getfacl /pool/backups
getfacl: Removing leading '/' from absolute path names
# file: pool/backups
# owner: root
# group: root
user::rwx
user:dh4:rwx
group::---
mask::rwx
other::---

notice the user dh4 has their own permissions while root is the owner and only user with any access to the directory. ACL allows dh4 to also have read/write access. It would be nice to have a graphical way to add, remove, and set permissions for a particular user or group using posixacl.

@Real-Gecko
Copy link
Owner

Latest version of Filemin supports SELinux contexts.
I never worked with ACL so adding this may take some time.

@Real-Gecko Real-Gecko reopened this May 24, 2017
@dv-anomaly
Copy link

No worries, thank you for considering the feature. The example above is pretty basic, but as you can imagine provides endless possibilities for permissions.

@Real-Gecko
Copy link
Owner

Yeah, seems cool, especially when you deal with shared hosting :)

@dv-anomaly
Copy link

dv-anomaly commented Nov 15, 2017

I'd like to put a $25 USD bounty on this to any developer willing to get this implemented. My requirement is 100% compatibility with posixacl, the ability to set permissions for individual users and groups.

@iliajie
Copy link
Contributor

iliajie commented Nov 15, 2017

It's a cool feature to have. I like it.

Old Java File Manager had full implementation if it?

@dv-anomaly
Copy link

You can take a look at this existing module.
http://webmin-fsacls.sourceforge.net/en/

The interface leaves much to be desired, but it works. This should be integrated into the permissions management window or add a new context menu for acls when right-clicking an item.

@iliajie
Copy link
Contributor

iliajie commented Nov 15, 2017

I will, thanks.

@dv-anomaly
Copy link

dv-anomaly commented Nov 15, 2017

I'll give it until the end of the month if you or another developer would prefer to receive the donation directly with Paypal. Otherwise I'll through it up on bountysource at the end of the month, which means they'll take that 10% fee. Thanks everyone, just let me know if you have any questions.

@qooob Yes I think the java file manager did have full compatibility as well. I haven't used it but based on screenshots it would appear so.

@iliajie
Copy link
Contributor

iliajie commented Nov 15, 2017

I'm just interested in doing it..

..not doing it for $25 😂

Before the end of the month? Maybe. Can't promise though.. There is a lot on my todo.

@dv-anomaly
Copy link

Well if you can always donate it back into the project or another project of you want. Either way defiantly claim it when your done. It's my pleasure to help out developers / projects when I can.

@Real-Gecko
Copy link
Owner

Closing due to inactivity, feel free to repoen if still actual.

@dhmetros
Copy link

dhmetros commented Feb 14, 2018

This issue seems to have dropped off due to lack of activity. This is a really nice feature to have. We would greatly benefit from it. OpenMediaVault has one that might be useful for design/implementation inspiration.
(Some screenshots from Google Search)
An ACL button above the file-folder list to open the ACL view/edit window:

folder-list-acl

The ACL window itself:
image

It's missing some things. For example, the file-folder list (first image) doesn't show what kind of permissions things have. "ls", for example, would give something more like what filemin already has, plus a "+" sign showing that it has ACLs, too. Also, listing all users in the ACL window makes it harder to parse what's there and what's not for long lists of users. If you wanted to keep the list of users/groups, separating them out with who has ACLs applied to them at the top would help.

@Real-Gecko Real-Gecko reopened this Feb 15, 2018
@RKDN
Copy link

RKDN commented May 22, 2019

I would love to see this implemented.

There are two commands:

getfacl - https://linux.die.net/man/1/getfacl
setfacl - https://linux.die.net/man/1/setfacl

@dv-anomaly
Copy link

dv-anomaly commented May 22, 2019

And when setting permissions it should either set the default, or have an option to also set the default. The default ALC is what's inherited by child directories.

EG: setfacl -Rm d:u:username:rwx /pool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants