reverse doesnt take dotted strings since django 1.10

Author: kevin1024

oauthadmin/views.py

@@ -13,6 +13,7 @@
 
 from oauthadmin.utils import import_by_path
 from oauthadmin.settings import app_setting
+import oauthadmin.views
 
 
 def destroy_session(request):
@@ -28,7 +29,7 @@ def login(request):
     # this view can be called directly by django admin site from
     # any url, or can be accessed by the login url if the urls
     # from this app were included
-    if request.path == reverse('oauthadmin.views.login'):
+    if request.path == reverse(oauthadmin.views.login):
         # if this view is being accessed from login url look for 'next'
         # in query string to use as destination after the login is complete
         next = request.GET.get('next')
@@ -39,7 +40,7 @@ def login(request):
         # don't support it yet)
         next = request.get_full_path()
 
-    redirect_uri = request.build_absolute_uri(reverse('oauthadmin.views.callback'))
+    redirect_uri = request.build_absolute_uri(reverse(oauthadmin.views.callback))
     if next:
         redirect_uri += '?next='+next
 
@@ -57,7 +58,7 @@ def login(request):
 
 def callback(request):
     if 'oauth_state' not in request.session:
-        return HttpResponseRedirect(request.build_absolute_uri(reverse('oauthadmin.views.login')))
+        return HttpResponseRedirect(request.build_absolute_uri(reverse(oauthadmin.views.login)))
     oauth = OAuth2Session(app_setting('CLIENT_ID'), state=request.session['oauth_state'])
     try:
         token = oauth.fetch_token(
@@ -66,7 +67,7 @@ def callback(request):
             authorization_response=app_setting('AUTH_URL') + "?" + request.GET.urlencode()
         )
     except (MismatchingStateError, InvalidGrantError):
-        return HttpResponseRedirect(request.build_absolute_uri(reverse('oauthadmin.views.login')))
+        return HttpResponseRedirect(request.build_absolute_uri(reverse(oauthadmin.views.login)))
 
     user = import_by_path(app_setting('GET_USER'))(token)
 
@@ -90,4 +91,4 @@ def logout(request):
 
 
 def logout_redirect(request):
-    return redirect(app_setting('BASE_URL') + 'logout?next=' + quote_plus(request.build_absolute_uri(reverse('oauthadmin.views.logout'))))
+    return redirect(app_setting('BASE_URL') + 'logout?next=' + quote_plus(request.build_absolute_uri(reverse(oauthadmin.views.logout))))

test/test_views.py

@@ -4,6 +4,7 @@
 from oauthlib.oauth2.rfc6749.errors import MismatchingStateError, InvalidGrantError
 from django.test.client import RequestFactory
 from django.core.urlresolvers import reverse
+import oauthadmin.views
 
 
 SESSION_VARIABLES = ['oauth_state', 'oauth_token', 'uid', 'user']
@@ -41,7 +42,7 @@ def test_login(app_setting, OAuth2Session, request_factory):
     OAuth2Session.return_value = mock.Mock(
         authorization_url = mock.Mock(return_value = ('https://foo', 'state-variable'))
     )
-    request = request_factory.get(reverse('oauthadmin.views.login'))
+    request = request_factory.get(reverse(oauthadmin.views.login))
     request.session = {}
     request.build_absolute_uri = mock.Mock(return_value='https://test.com/construct-redirect')
 
@@ -57,7 +58,7 @@ def test_login_redirect_uri(OAuth2Session, request_factory):
     OAuth2Session.return_value = mock.Mock(
         authorization_url = mock.Mock(return_value = ('https://foo', 'state-variable'))
     )
-    request = request_factory.get(reverse('oauthadmin.views.login'))
+    request = request_factory.get(reverse(oauthadmin.views.login))
     request.session = {}
     request.build_absolute_uri = mock.Mock(return_value='https://test.com/construct-redirect')
 
@@ -74,7 +75,7 @@ def test_login_redirect_uri_with_next_from_url(OAuth2Session, request_factory):
     OAuth2Session.return_value = mock.Mock(
         authorization_url = mock.Mock(return_value = ('https://foo', 'state-variable'))
     )
-    request = request_factory.get(reverse('oauthadmin.views.login') + '?next=/admin/content/')
+    request = request_factory.get(reverse(oauthadmin.views.login) + '?next=/admin/content/')
     request.session = {}
     request.build_absolute_uri = mock.Mock(return_value='https://test.com/construct-redirect')
 
@@ -143,7 +144,7 @@ def test_callback_with_invalid_grant(import_by_path, app_setting, OAuth2Session,
 @mock.patch('oauthadmin.views.app_setting')
 @mock.patch('oauthadmin.views.import_by_path')
 def test_callback(import_by_path, app_setting, OAuth2Session, request_factory):
-    request = request_factory.get(reverse('oauthadmin.views.callback'))
+    request = request_factory.get(reverse(oauthadmin.views.callback))
     request.session = {'oauth_state': 'state-variable'}
     OAuth2Session.return_value = mock.Mock(
         fetch_token = mock.Mock(return_value = 'token')
@@ -163,7 +164,7 @@ def test_callback(import_by_path, app_setting, OAuth2Session, request_factory):
 @mock.patch('oauthadmin.views.app_setting')
 @mock.patch('oauthadmin.views.import_by_path')
 def test_callback_redirect_to_next(import_by_path, app_setting, OAuth2Session, request_factory):
-    request = request_factory.get(reverse('oauthadmin.views.callback') + '?next=/admin/content/')
+    request = request_factory.get(reverse(oauthadmin.views.callback) + '?next=/admin/content/')
     request.session = {'oauth_state': 'state-variable'}
     OAuth2Session.return_value = mock.Mock(
         fetch_token = mock.Mock(return_value = 'token')