Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add a test for SetURLUtm utility function #310

Open
3 tasks
mbifulco opened this issue Jul 19, 2020 · 3 comments
Open
3 tasks

[Feature] Add a test for SetURLUtm utility function #310

mbifulco opened this issue Jul 19, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mbifulco
Copy link
Member

User Story

n/a, really - this is more of a tech debt task

This issue is to track the work around having a test written for setUrlUtm in /src/utils/urlUtils.js. We had a production failure today due to some incomplete fallback cases written for that function

Acceptance Criteria

  • Test coverage should reach setUrlUtm
  • Tests should pass
  • setUrlUtm should be linted - I'm not sure it is being checked right now.

Is your feature request related to a problem? Please describe.

On 7/19/2020, we had reports of the /business page crashing for some users who were trying to load certain data in the Safari browser. This was hotfixed in #309, but no tests were written.

Describe the solution you'd like

A good test case (or cases) for the above function, and any needed code changes to the function itself!

@mbifulco mbifulco added the enhancement New feature or request label Jul 19, 2020
@mbifulco mbifulco added this to the V1 Refinement milestone Jul 19, 2020
@juanri0s
Copy link

Is this task open for me to pickup? I'd like to get some tests going here 😄

@magnificode
Copy link
Member

All you @juanri0s!

@magnificode
Copy link
Member

@juanri0s - were you able to make any headway here sir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants