Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InfluxdbHttpWriter does not allow HTTPs #3

Open
foxthedream opened this issue Oct 9, 2017 · 0 comments
Open

InfluxdbHttpWriter does not allow HTTPs #3

foxthedream opened this issue Oct 9, 2017 · 0 comments

Comments

@foxthedream
Copy link

Was trying to get the library to use HTTPs. Tried various ways, URIs, configurations, specifying different writers and nothing worked. I took a look at the code. I think that the problem is that the InfulxdbHttpWriter, the class that actually does the HTTP posting, has an private URI object. The way this object gets built up doesn't allow anyone to use HTTPs. You cannot specify HTTPs on the InfluxConfig object and the URI overload parses the URI into an InfluxConfig object and then back again into an URI. You lose the fact that the URI wanted or needed HTTPs. My suggestion would be to not telescope to the InfluxConfig overload but rather set the internatl URI to the one passed into the constructor. From a consumer's perspective this is the behaviour I expected and was surprised to see it was different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant