Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageHeaderTitle ignores ouiaId custom attributes #1559

Open
gkarat opened this issue Jun 14, 2022 · 3 comments
Open

PageHeaderTitle ignores ouiaId custom attributes #1559

gkarat opened this issue Jun 14, 2022 · 3 comments
Labels
components update to components package

Comments

@gkarat
Copy link
Contributor

gkarat commented Jun 14, 2022

PageHeaderTitle component doesn't expect ouiaId as a property. Not sure whether this is a bug, or rather a missing feature, it will be good to be able to set a custom ouiaId to this component -- the same way PF components behave (this was a reason to abandon the component and use the PF Title instead).

<Title headingLevel="h1" size="2xl" className={pageHeaderTitleClasses} widget-type="InsightsPageHeaderTitle">

@gkarat gkarat added the components update to components package label Jun 14, 2022
@Hyperkid123
Copy link
Contributor

@gkarat The component extends the TitleProps from PF. We do not pass the rest of the props to the title component anyway. So we have to fix both of these things.

@gkarat
Copy link
Contributor Author

gkarat commented Jun 14, 2022

@Hyperkid123, isn't the OUIAProps interface inherited by TitleProps? If yes, I don't think we have to edit the PF code anyhow.

@Hyperkid123
Copy link
Contributor

I am not 100% sure but I do remember some problems with OUID props when working with PF TS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components update to components package
Projects
None yet
Development

No branches or pull requests

2 participants