New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frontend-components-remediations should list @scalprum/react-core as the package dependency #1932

Open

gkarat opened this issue Nov 2, 2023 · 0 comments

Labels

bug remediations

Contributor

gkarat commented Nov 2, 2023

frontend-components/packages/remediations/src/RemediationButton/index.js

Line 3 in 48903ef

import { ScalprumComponent } from '@scalprum/react-core';

: the component imports from @scalprum/react-core, however it is not listed as a direct or peer dependency in package.json.

This, for example, causes RedHatInsights/insights-advisor-frontend#1189 (review).

gkarat added bug remediations labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment