Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axios security issue #1979

Open
kelvah opened this issue Mar 7, 2024 · 3 comments
Open

axios security issue #1979

kelvah opened this issue Mar 7, 2024 · 3 comments
Assignees

Comments

@kelvah
Copy link

kelvah commented Mar 7, 2024

Hi,

We got a new CVE ticket about axios for our project (OCM):
https://issues.redhat.com/browse/OCMUI-1491

CVE-2023-45857 axios: exposure of confidential data stored in cookies
https://bugzilla.redhat.com/show_bug.cgi?id=2248979

An issue discovered in Axios 1.5.1 inadvertently reveals the confidential XSRF-TOKEN stored in cookies by including it in the HTTP header X-XSRF-TOKEN for every request made to any host allowing attackers to view sensitive information.

https://github.com/axios/axios/issues/6006
https://github.com/jeffbski/wait-on/pull/147

@redhat-cloud-services/frontend-components-utilities is on axios@^0.28.0
https://github.com/RedHatInsights/frontend-components/blob/master/packages/utils/package.json#L42

It's not clear if the reported issue was introduced with 1.5.1. Anyway, older versions of axios got their share of CVEs reported over time.

Do you think it could be possible to update it to latest?
Thanks!

@Hyperkid123 Hyperkid123 self-assigned this Mar 8, 2024
@Hyperkid123
Copy link
Contributor

We can't upgrade to ^1.x.x as of yet. There are still some dependencies that require the old version. We are working on these at the moment.

@Ginxo
Copy link

Ginxo commented Mar 28, 2024

two new CVEs related with this arrived to OCMUI

https://issues.redhat.com/browse/OCMUI-1554
https://issues.redhat.com/browse/OCMUI-1596

for now we decided to add resolution since yarn was resolving latest axios library (no matter @redhat-cloud-services one) so it was about to remove any reference to old one on lock file. We would like to avoid such kind of configuration in our side to avoid future problems caused by this kind of overriding.

Any effort/update on this will be appreciated. Thanks

@Hyperkid123
Copy link
Contributor

The update will be a part of the next major release. There are breaking changes between 0.2.x and 1.x. Next major release should happen this Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants