Skip to content

feat: add landing-landingPage layoutType prop to landing module - #894

Draft
OlhaTmlk wants to merge 1 commit into
RedHatInsights:masterfrom
OlhaTmlk:dashboard-type
Draft

feat: add landing-landingPage layoutType prop to landing module#894
OlhaTmlk wants to merge 1 commit into
RedHatInsights:masterfrom
OlhaTmlk:dashboard-type

Conversation

@OlhaTmlk

@OlhaTmlk OlhaTmlk commented May 18, 2026

Copy link
Copy Markdown

Description

  • Add layoutType: landing-landingPage prop to the landing module route configuration
  • This prop is consumed by the widget-layout repo

@OlhaTmlk
OlhaTmlk requested a review from a team as a code owner May 18, 2026 11:58
@coderabbitai

coderabbitai Bot commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 2f3e8725-0300-47d3-ab38-4b9245ef1c39

📥 Commits

Reviewing files that changed from the base of the PR and between a8512b2 and 03324fd.

📒 Files selected for processing (1)
  • frontend.yml

Summary by CodeRabbit

  • Chores
    • Updated landing page routing configuration.

Walkthrough

This PR configures the root route of the landing-page-frontend template to pass a layoutType property set to landing-landingPage. The change is a minimal configuration addition to an existing route handler with no other modifications to the file.

Changes

Landing Page Route Configuration

Layer / File(s) Summary
Root route layout type props
frontend.yml		 The root route (pathname: /, exact: true) is configured with a props section that sets layoutType to landing-landingPage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete and missing several required sections from the template including impacted UI links, RHCLOUD issue reference, screenshots, and the checklist. Add missing sections: impacted UI information with links, RHCLOUD issue reference, before/after screenshots, and complete the provided checklist items.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately and specifically describes the main change: adding a layoutType prop to the landing module route configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@OlhaTmlk
OlhaTmlk marked this pull request as draft May 18, 2026 12:29
@OlhaTmlk

OlhaTmlk commented May 18, 2026

Copy link
Copy Markdown
Author

/retest

@OlhaTmlk
OlhaTmlk marked this pull request as ready for review May 18, 2026 12:47
@Hyperkid123
Hyperkid123 marked this pull request as draft May 19, 2026 07:52
@Hyperkid123

Hyperkid123 commented May 19, 2026

Copy link
Copy Markdown
Contributor

This needs to be in prod first: RedHatInsights/widget-layout#336

@riccardo-forina

riccardo-forina commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This predates the restructure (PR #925 / PR #926) — the route shell it targets was reworked and the layoutType prop may no longer be consumed where it was headed. Suggest closing and re-filing against the current structure if the feature is still needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OlhaTmlk @Hyperkid123 @riccardo-forina