From 70a74c7697fc8a270e13629ae5753020dac1c1fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20Olek=C5=A1=C3=A1k?= Date: Thu, 30 May 2024 20:01:29 +0200 Subject: [PATCH] Update to Node v18 (#2112) --- .travis.yml | 3 ++- README.md | 6 +++--- build_deploy.sh | 2 +- pr_check.sh | 2 +- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index ad6d3c381..edfa373d3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -2,8 +2,9 @@ language: node_js sudo: required notifications: email: false +dist: focal node_js: -- '16' +- '18' install: - npm ci jobs: diff --git a/README.md b/README.md index b8e6e21a6..79cb0009f 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ Red Hat Insights Vulnerability service is used to assess and monitor the status of security vulnerabilities on RHEL systems, understand the level of exposure of infrastructure, and plan a course of action. This is the front-end repository for this service. ## First time setup -1. Make sure you have [Node.js](https://nodejs.org/en/) version >= 16 installed +1. Make sure you have [Node.js](https://nodejs.org/en/) version >= 18 installed 2. Run [script to patch your `/etc/hosts`](https://github.com/RedHatInsights/insights-proxy/blob/master/scripts/patch-etc-hosts.sh) 3. Make sure you are using [Red Hat proxy](http://hdn.corp.redhat.com/proxy.pac) @@ -58,10 +58,10 @@ Any push to the following branches will trigger a build in [vulnerability-ui-bui ## Internationalization ### Translation keys -Translation keys are saved in [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js). +Translation keys are saved in [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js). ### Generating translation keys -Each time you add a new translation keys you need to run `npm run translations`, which will automatically generate JSON files for every language into [`locales/`](https://github.com/RedHatInsights/vulnerability-ui/tree/master/locales) folder based on the entries in the [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js). +Each time you add a new translation keys you need to run `npm run translations`, which will automatically generate JSON files for every language into [`locales/`](https://github.com/RedHatInsights/vulnerability-ui/tree/master/locales) folder based on the entries in the [`messages.js`](https://github.com/RedHatInsights/vulnerability-ui/blob/master/src/Messages.js). ### Using translated strings There are two ways to use translated strings: diff --git a/build_deploy.sh b/build_deploy.sh index 541d03fa9..be10bb4c3 100755 --- a/build_deploy.sh +++ b/build_deploy.sh @@ -9,7 +9,7 @@ export COMPONENT="vulnerability-ui" export IMAGE="quay.io/cloudservices/vulnerability-ui" export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace export APP_ROOT=$(pwd) -export NODE_BUILD_VERSION=16 +export NODE_BUILD_VERSION=18 COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master set -exv diff --git a/pr_check.sh b/pr_check.sh index 07c1957a4..4885144b9 100755 --- a/pr_check.sh +++ b/pr_check.sh @@ -9,7 +9,7 @@ export COMPONENT="vulnerability-ui" export IMAGE="quay.io/cloudservices/vulnerability-ui" export WORKSPACE=${WORKSPACE:-$APP_ROOT} # if running in jenkins, use the build's workspace export APP_ROOT=$(pwd) -export NODE_BUILD_VERSION=16 +export NODE_BUILD_VERSION=18 COMMON_BUILDER=https://raw.githubusercontent.com/RedHatInsights/insights-frontend-builder-common/master # --------------------------------------------