-
Notifications
You must be signed in to change notification settings - Fork 51
CherryPicked: [cnv-4.19] Add istio-ca-crl to the allowed list #2982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: cnv-4.19
Are you sure you want to change the base?
CherryPicked: [cnv-4.19] Add istio-ca-crl to the allowed list #2982
Conversation
##### Short description: Istio 1.19 includes a new feature Certificate Revocation List (CRL). As a consequence, a new configMap is appearing on the openshift-cnv namespace called `istio-ca-crl`. This PR is adding it to the list of allowed elements in the openshfit-cnv. ##### More details: Follow-up of #1044 ##### What this PR does / why we need it: N/A ##### Which issue(s) this PR fixes: N/A ##### Special notes for reviewer: N/A ##### jira-ticket: N/A <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved error message clarity for missing labels, now displaying label information in a more readable format. * Added support for "istio-ca-crl" label handling in resource validation checks. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features:
🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
/lgtm |
|
/verified |
cherry-pick #2940 into cnv-4.19
requested-by by target-branch label