From 3f955ffb2eb089dbb682fcee13993110d4c1b2aa Mon Sep 17 00:00:00 2001
From: Ramon Lobillo Mateos <62110535+rlobillo@users.noreply.github.com>
Date: Wed, 3 Dec 2025 15:31:44 +0100
Subject: [PATCH] Add istio-ca-crl to the allowed list (#2940)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

##### Short description:
Istio 1.19 includes a new feature Certificate Revocation List (CRL).
As a consequence, a new configMap is appearing on the openshift-cnv
namespace called `istio-ca-crl`.
This PR is adding it to the list of allowed elements in the
openshfit-cnv.

##### More details:
Follow-up of
https://github.com/RedHatQE/openshift-virtualization-tests/pull/1044

##### What this PR does / why we need it:
N/A
##### Which issue(s) this PR fixes:
N/A
##### Special notes for reviewer:
N/A
##### jira-ticket:
N/A

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Improved error message clarity for missing labels, now displaying
label information in a more readable format.
* Added support for "istio-ca-crl" label handling in resource validation
checks.

<sub>✏️ Tip: You can customize this high-level summary in your review
settings.</sub>

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---
 .../relationship_labels/test_all_cnv_resources.py              | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py b/tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py
index dd82b10942..923c3a4923 100644
--- a/tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py
+++ b/tests/install_upgrade_operators/relationship_labels/test_all_cnv_resources.py
@@ -29,6 +29,7 @@
     "hyperconverged-cluster-operator-lock",
     "kubevirt-ipam-controller-webhook-service",
     "istio-ca-root-cert",
+    "istio-ca-crl",
 ]
 PRINT_COMMAND = '{printf "%s%s",sep,$0;sep=","}'
 AWK_COMMAND = f"awk '{PRINT_COMMAND}'"
@@ -136,7 +137,7 @@ def test_relationship_labels_all_cnv_resources(
 
                         else:
                             errors.setdefault(kind, []).append(
-                                f"{name} has missing labels: {labels} and is not managed by olm"
+                                f'{name} has missing labels. Current labels are "{labels}" and is not managed by olm'
                             )
             else:
                 errors.setdefault(kind, []).append(f"{name} resource not found")