-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to paste their own URLs #3
Comments
I totally agree with this idea! |
Would adding the url to a query string be a good idea? i can see that the url field in the site is rendered as several span elements so im not sure how you would make it editable Edit: I'm currently trying to figure it out |
@creepinson, a good point. I don't think the same component could be reused as an input for the custom URL. I like the idea of a query parameter, yet it would be great to be able to enter that URL as a part of site experience, what do you think? I'd absolutely love to review your changes once you're done :) Thanks. When we receive a URL string, we can parse it via My concern with such feature is in long URLs. How should we handle a URL that is too long? For example, an automatically generated URL, or the one with a lot of query parameters. |
Hmm, that's also a good polnt. I'm not sure what we should do about that yet. |
I would favor just allowing the user to paste any length and insert a horizontal scroll around the whole explanation ui. I bet a few users would be disappointed if we cap it. |
If you could push your branch I or somebody else might be able to help ;) |
@creepinson the current layout is not in its greatest in terms of handling horizontal overflow on big screens. I think the design itself needs to be redone in general. As much as I admire top/bottom asymmetric transitions of explanation blocks, they are failure-prone, as their dimensions are fixed, yet their content depends on the translations. It also puts quite a strict limitation over the amount of content that can be put into each section, limiting the otherwise more profound explanation. I was thinking to always fix the URL preview part to the top and display the explanatory content at the bottom, as you can see on mobile right now. Without any absolute elements. This will require a few move-arounds in the layout, but is totally doable.
Do you find this a good idea? I'm curious to hear what you folks think. |
This sounds good. How will it handle long urls though? Like will it wrap or have a horizontal scroll bar? |
Ok, I made a fork because that's what I thought I was supposed to do. It still looks weird but I uploaded what I have so far. Here is the link to it: |
Forking is correct the way. Repos don't allow non members to create branches on default settings. Making the UI more responsive before introducing the feature is probably the right move. |
It would be cool to be able to insert any URL and have the site explain it.
Good work so far btw 👍
The text was updated successfully, but these errors were encountered: