Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalization #5

Open
Tazeg opened this issue May 9, 2020 · 3 comments
Open

Internationalization #5

Tazeg opened this issue May 9, 2020 · 3 comments

Comments

@Tazeg
Copy link

Tazeg commented May 9, 2020

Thanks for adding translations. I may help english/french if you set a file type format.

@hehehai
Copy link
Contributor

hehehai commented May 10, 2020

@kettanaito Chinese +1 😀

@kettanaito
Copy link
Member

Hey, folks. I've just merged an internationalization support to master. If you'd have a free minute, I'd appreciate if you could add a translation in one of the languages you speak.

Adding a translation

  1. Add a respective locale file to this directory: https://github.com/Redd-Developer/howurls.work/tree/1b37709eb7a8b443633c31d16d29a9587886539c/src/locales. Please use ISO language codes for file names.
  2. Provide localizations for all the keys you can find in en-US.json. When in doubt, feel free to ask here, or in the pull request.
  3. Add a new language to the <select> element in the language selector component:
    <option value="en-US">English</option>
    <option value="uk-UA">Українська</option>
    <option value="ru-RU">Русский</option>
    . Please give it the value prop equal to the name of the locale file from the previous step.

You can preview your localization locally by running:

$ yarn install
$ yarn start

Please let me know if there's any questions. Thank you!

@hehehai
Copy link
Contributor

hehehai commented May 13, 2020

@kettanaito Chinese support #15

@kettanaito kettanaito pinned this issue May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants