Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Redpoint.AutoDiscovery to allow key-value pairs and improve API #24

Open
hach-que opened this issue Oct 31, 2024 · 0 comments
Open
Labels
migrated from gitlab Migrated from GitLab

Comments

@hach-que
Copy link
Member

A few things to do here:

  • Replace name with ServiceIdentifier and ServiceQuery in INetworkAutoDiscovery.
    • ServiceIdentifier should be readonly record class that has a constructor that takes instanceId and serviceId that generates {instanceId}.{serviceId}._tcp.local, and a static factory method that takes a dnsName that lets you specify the whole thing.
    • ServiceQuery should be a readonly record class that has a constructor that takes serviceId and generates {serviceId}._tcp.local and a static factory method that takes a dnsName that lets you specify the whole thing.
    • This should prevent the easy accident of specifying name is in the wrong format for register/query (since they are slightly different), which leads to no services being discovered on the network.
  • Add support for the key-value pairs of DnsServiceConstructInstance in the service instance, and retrieving this information on queries. We want to be able to use this information so that services can advertise public keys in DNS for establishing secure connections.
@hach-que hach-que added the migrated from gitlab Migrated from GitLab label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
migrated from gitlab Migrated from GitLab
Projects
None yet
Development

No branches or pull requests

1 participant