Skip to content

Commit bd8bb4e

Browse files
committed
Add some TODOs
1 parent ad3eef3 commit bd8bb4e

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ so it might fail or do the wrong thing in some edge cases I haven't considered (
7070
repo in a bad state afterward).
7171

7272
Not all of the various command-line options to the underlying `git clone`, `git submodule add`, etc.
73-
are supported.
73+
are supported. In particular, recursive clone is not currently supported.
7474

7575
"Cone" mode for sparse checkout is not currently supported.
7676

git-partial-submodule.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@
4444
'clone',
4545
help = "Clone partial submodules from .gitmodules.")
4646
cloneCmdParser.add_argument('paths', nargs='*', default=[], help='Submodule path(s) to clone (if unspecified, all submodules)')
47+
# TODO: recursive clone option
4748

4849
saveSparseCmdParser = subparsers.add_parser(
4950
'save-sparse',
@@ -179,6 +180,8 @@ def ReadGitmodules(worktreeRoot):
179180
args.repository,
180181
submoduleRelPath)
181182

183+
# TODO: if sparse, save the initial set of sparse patterns to .gitmodules
184+
182185
elif args.command == 'clone':
183186
# Load .gitmodules information
184187
gitmodules = ReadGitmodules(worktreeRoot)
@@ -194,6 +197,8 @@ def ReadGitmodules(worktreeRoot):
194197
else:
195198
submoduleRelPathsToProcess = gitmodules.byPath.keys()
196199

200+
# TODO: filter by active submodules
201+
197202
submodulesSkipped = 0
198203
for submoduleRelPath in submoduleRelPathsToProcess:
199204
if submoduleRelPath not in gitmodules.byPath:

0 commit comments

Comments
 (0)