Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Exclusion tag for mapmakers (or similar function) #16

Open
crux-f opened this issue Apr 27, 2022 · 0 comments · May be fixed by #19
Open

[Enhancement]: Exclusion tag for mapmakers (or similar function) #16

crux-f opened this issue Apr 27, 2022 · 0 comments · May be fixed by #19
Assignees
Labels
enhancement New feature or request

Comments

@crux-f
Copy link

crux-f commented Apr 27, 2022

Hi Reldeam!

This is a bit of a niche request (shocking, I know) but as I have been tinkering with a few more datapack ideas recently, I noticed that in the plugin's "remove vanilla trades" functionality, it disables all trades the game assigns to it, not just from the trading pool.

This means if custom villagers are spawned in using /summon, if their profession is one the plugin has set to "disable vanilla trades", it will remove those custom trades as well.

Is there a possibility of some sort of scoreboard tag or other internal functionality that could be implemented to allow for these custom villagers to function alongside the plugin?

Obviously this can be sidestepped by using Wandering Traders, however it does mean that any existing adventure maps or similar setups using custom villagers will not work.

Definitely a low priority enhancement, of course.

Overall this plugin has been working absolutely flawlessly on 1.18.2 Paper, and I thank you again for your hard work!

@crux-f crux-f added the enhancement New feature or request label Apr 27, 2022
@crux-f crux-f linked a pull request Oct 12, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants