Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set bigger size for circular buffer #11

Open
TechInterMezzo opened this issue Jul 11, 2022 · 1 comment
Open

Allow to set bigger size for circular buffer #11

TechInterMezzo opened this issue Jul 11, 2022 · 1 comment

Comments

@TechInterMezzo
Copy link

TechInterMezzo commented Jul 11, 2022

At the moment the circular buffer size is hardcoded to 4096:
https://github.com/Reloaded-Project/Reloaded.Injector/blob/master/Source/Reloaded.Injector/Injector.cs#L40

Would it be possible to make that an optional parameter for the Injector constructor?
I want to use a struct as a remote call argument that is too big for the current circular buffer.

EDIT:
And maybe it would be good to check parameterPtr after this line:
https://github.com/Reloaded-Project/Reloaded.Injector/blob/master/Source/Reloaded.Injector/Injector.cs#L115
If it is zero then the parameter struct couldn't be fit into the circular buffer and an exception should be thrown.

@Sewer56
Copy link
Member

Sewer56 commented Jul 11, 2022

I don't mind adding an API for that as it's a simple change.

Just please note that I don't maintain this specific library (only this library) anymore (also am on vacation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants