Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong dictionary NPE guard #151

Open
aploskov opened this issue Jan 15, 2020 · 0 comments
Open

Wrong dictionary NPE guard #151

aploskov opened this issue Jan 15, 2020 · 0 comments

Comments

@aploskov
Copy link

core/jdiameter/impl/src/main/java/org/jdiameter/client/impl/fsm/PeerFSMImpl.java:343
contains diameter != null, but at the previous line ValidatorLevel incomingLevel = dictionary.getReceiveLevel();. It's not a problem, until dictionary is a singleton, but may produce bugs, if the dictionary implementation will change.

I think, you should inline incoming level and change the debug message in the else statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aploskov