Skip to content

Commit 5cdd317

Browse files
Inform about cutter bundled rizin
1 parent ade71cc commit 5cdd317

File tree

3 files changed

+12
-5
lines changed

3 files changed

+12
-5
lines changed

Diff for: README.md

+7
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,13 @@ by current user (the user launching the plugin), or there exist environment
5151
varibles `$TMPDIR` or `$TMP` and those are writable as well.
5252
So it should be either `$PWD` or `$TMP` or `$TMPDIR`.
5353

54+
If you cannot see dialogs or messages when intercting with plugin in cutter UI,
55+
make sure that you have a cutter installation with bundled rizin. If your cutter
56+
installation uses pre-installed rizin, then the way the plugin is written, you'll
57+
end up using rizin's command line plugin through the cutter UI, and will only be
58+
able to see output through the command line. Cutter with bundled rizin is very
59+
important!
60+
5461
If rizin fails to automatically load the plugin, you can
5562

5663
- Open rizin and run `e dir.plugins`. You'll get the exact path where

Diff for: Source/Cutter/Decompiler.cpp

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ void *ReaiDec::pollAndSignalFinished (ReaiDec *self) {
4242

4343
// keep polling for decompilation
4444
while (self->isRunning()) {
45-
REAI_LOG_TRACE ("still polling... going for sleep for 2 seconds");
46-
rz_sys_sleep (2); // 2 seconds
45+
REAI_LOG_TRACE ("still polling...");
4746
}
4847

4948
// get decompiled code after finished

Diff for: Source/Cutter/Ui/FunctionSimilarityDialog.cpp

+4-3
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,8 @@ FunctionSimilarityDialog::FunctionSimilarityDialog (QWidget* parent) : QDialog (
102102
confidenceLabel->setText (QString ("%1 % min confidence").arg (value));
103103
});
104104

105-
enableDebugModeCheckBox = new QCheckBox ("Enable debug mode", this);
105+
enableDebugModeCheckBox =
106+
new QCheckBox ("Restrict suggestions to debug symbols only?", this);
106107
mainLayout->addWidget (enableDebugModeCheckBox);
107108
enableDebugModeCheckBox->setCheckState (Qt::CheckState::Checked);
108109
}
@@ -116,8 +117,8 @@ void FunctionSimilarityDialog::on_FindSimilarNames() {
116117
QByteArray fnNameByteArr = fnName.toLatin1();
117118
CString fnNameCStr = fnNameByteArr.constData();
118119

119-
Float32 confidence = confidenceSlider->value() / 100.f;
120-
Bool debugMode = enableDebugModeCheckBox->checkState() == Qt::CheckState::Checked;
120+
Uint32 confidence = confidenceSlider->value();
121+
Bool debugMode = enableDebugModeCheckBox->checkState() == Qt::CheckState::Checked;
121122

122123
QString maxResultCountStr = maxResultsInput->text();
123124
bool success = false;

0 commit comments

Comments
 (0)