Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation docs #60

Open
4 tasks
daniloab opened this issue Apr 15, 2022 · 0 comments
Open
4 tasks

update installation docs #60

daniloab opened this issue Apr 15, 2022 · 0 comments

Comments

@daniloab
Copy link

daniloab commented Apr 15, 2022

hi, thanks for the repository and docs. Also, I see some improvements to aggregate to the amazing job.

I guess I will have a free time into the next days and I can send a pull request doing these items below. Until there if someone can feel free to do it:

  • add the same topics from npm to yarn
  • upgrade webpack section to the actual one from example
    update from
module.exports = {
  webpack: (config, { isServer, webpack }) => {
    if (!isServer) {
      // Ensures no server modules are included on the client.
      config.plugins.push(new webpack.IgnorePlugin(/lib\/server/));
    }

    return config;
  },
};

to https://github.com/RevereCRE/relay-nextjs/blob/main/example/next.config.js

module.exports = {
  webpack: (config, { isServer, webpack }) => {
    if (!isServer) {
      // Ensures no server modules are included on the client.
      config.plugins.push(new webpack.IgnorePlugin(/lib\/server/));
    }

    return config;
  },
};
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant