Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to C# standard Tar classes (away from SharpZipLib) once we use .NET 7 #4156

Closed
hhyyrylainen opened this issue Feb 24, 2023 · 4 comments · Fixed by #5053
Closed

Switch to C# standard Tar classes (away from SharpZipLib) once we use .NET 7 #4156

hhyyrylainen opened this issue Feb 24, 2023 · 4 comments · Fixed by #5053
Labels
C# easy impeded programming saving
Milestone
Release 0.6.6

Comments

@hhyyrylainen
Copy link
Member

As they have had a bug that impacted us in their newer versions that I already reported even and nothing has happened: icsharpcode/SharpZipLib#827 so I'm not super confident in the library anymore that it won't randomly have new serious data corruption bugs like I had to fix for the update to version 1.4.2: #4152 so once we are on Godot 4 and have .NET 7 we should be able to switch to: https://learn.microsoft.com/en-us/dotnet/api/system.formats.tar.tarreader?view=net-7.0
@hhyyrylainen
Copy link
Member Author

I just ran into a save corruption bug again so, this switch will be important.

@hhyyrylainen hhyyrylainen changed the title Switch to C# standard Tar classes (from SharpZipLib) once we use .NET 7 Switch to C# standard Tar classes (away from SharpZipLib) once we use .NET 7 Apr 24, 2023
@hhyyrylainen hhyyrylainen mentioned this issue May 26, 2023
Closed
@hhyyrylainen
Copy link
Member Author

For the time being I made a fix by downgrading the library version: #4379

@hhyyrylainen hhyyrylainen mentioned this issue May 26, 2023
Closed
@hhyyrylainen hhyyrylainen added this to the Release 0.6.6 milestone Mar 15, 2024
@hhyyrylainen hhyyrylainen self-assigned this Mar 22, 2024
@hhyyrylainen hhyyrylainen removed their assignment Mar 22, 2024
@hhyyrylainen hhyyrylainen removed this from the Release 0.6.6 milestone Mar 22, 2024
@hhyyrylainen
Copy link
Member Author

So apparently this is only in .NET 7 and newer. So we'll need to wait until Godot 4 updates to the LTS 8 .NET version.

@hhyyrylainen
Copy link
Member Author

hhyyrylainen commented Apr 19, 2024 •
edited
Loading

This is the latest info related to that I found: godotengine/godot#71241

It looks like it'll still take a while.

Edit: I'm actually wrong, it is possible to specify the newer runtime already.

@hhyyrylainen hhyyrylainen added this to the Release 0.6.6 milestone Apr 19, 2024
@hhyyrylainen hhyyrylainen mentioned this issue Apr 19, 2024
Merged
4 tasks
@hhyyrylainen hhyyrylainen moved this to Done in Thrive Planning Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C# easy impeded programming saving
Projects
Thrive Planning
Archived in project
Milestone
Release 0.6.6
Development

Successfully merging a pull request may close this issue.

Updated to .NET 8 runtime and C# 12 and switched to standard Tar classes Revolutionary-Games/Thrive
1 participant
@hhyyrylainen