-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for screen-recording media type #1585
Comments
@oPromessa I'm impressed with how thorough your branch is -- nice work! A couple pointers: The "screen_shot" key should be added in Additionally, in the iPhoto test, you'll need to update the test data at |
|
The docs building needs work. Don't worry about this as I don't build the docs until I do the release. For individual PRs, just update the appropriate files but don't build the docs as they will get re-built as part of my release process. |
Yes, you're right. I'll fix it. |
The test_cli.py is a monster....on my to do list to break this up into smaller chunks as it has become very unwieldy. Basically, for the tests that are failing, you need to track down where they're getting the "expected" data from. For example, in There may be other places that need to be modified. |
Had to set property screen-recording to None for <= _PHOTOS_4_VERSION). |
Is your feature request related to a problem? Please describe.
Describe the solution you'd like
Describe alternatives you've considered
N/A
Additional context
Errors:
The text was updated successfully, but these errors were encountered: