refactor: remove redundant interrupted bool from ActiveRequest

Use `interrupt_event.is_set()` as the single source of truth instead of
maintaining a separate boolean that mirrors the Event state.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: nimdraugsael

src/bot/orchestrator.py

@@ -116,7 +116,6 @@ class ActiveRequest:
     user_id: int
     interrupt_event: asyncio.Event = field(default_factory=asyncio.Event)
     progress_msg: Any = None  # telegram Message object
-    interrupted: bool = False
 
 
 class MessageOrchestrator:
@@ -1304,11 +1303,10 @@ async def _handle_stop_callback(
         if not active:
             await query.answer("Already completed.", show_alert=False)
             return
-        if active.interrupted:
+        if active.interrupt_event.is_set():
             await query.answer("Already stopping...", show_alert=False)
             return
 
-        active.interrupted = True
         active.interrupt_event.set()
         await query.answer("Stopping...", show_alert=False)
 

tests/unit/test_bot/test_stop_button.py

@@ -65,7 +65,7 @@ def test_defaults(self):
         req = ActiveRequest(user_id=42)
         assert req.user_id == 42
         assert isinstance(req.interrupt_event, asyncio.Event)
-        assert req.interrupted is False
+        assert not req.interrupt_event.is_set()
         assert req.progress_msg is None
 
 
@@ -95,7 +95,6 @@ async def test_owner_can_stop(self, orchestrator):
         await orchestrator._handle_stop_callback(update, context)
 
         assert event.is_set()
-        assert active.interrupted is True
         query.answer.assert_awaited_once_with("Stopping...", show_alert=False)
         progress_msg.edit_text.assert_awaited_once_with(
             "Stopping...", reply_markup=None
@@ -122,7 +121,6 @@ async def test_non_owner_blocked(self, orchestrator):
         await orchestrator._handle_stop_callback(update, context)
 
         assert not event.is_set()
-        assert not active.interrupted
         query.answer.assert_awaited_once_with(
             "Only the requesting user can stop this.", show_alert=True
         )
@@ -166,7 +164,7 @@ async def test_double_stop_prevention(self, orchestrator):
         active = ActiveRequest(
             user_id=100, interrupt_event=event, progress_msg=AsyncMock()
         )
-        active.interrupted = True  # already stopped once
+        event.set()  # already stopped once
         orchestrator._active_requests[100] = active
 
         query = AsyncMock()