Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix critical warnings when using buffer tracer #122

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix critical warnings when using buffer tracer #122

wants to merge 1 commit into from

Conversation

alehed
Copy link

@alehed alehed commented May 16, 2023 •
edited
Loading

This fixes a copy-paste mistake that caused a bunch of critical warnings:

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

GStreamer-CRITICAL **: 11:38:05.911: gst_buffer_get_size: assertion 'GST_IS_BUFFER (buffer)' failed

This is caused because buffer lists are passed to the function meant to process buffers. This causes at least the buffer tracer to not work for buffer lists.

@alehed
Use correct hook in pad_push_list_pre
af6d4a8 
This fixes a copy-paste mistake that caused a bunch of
critical glib warnings when using the buffer tracer.
@alehed alehed changed the title Use correct hook in pad_push_list_pre Fix glib critical warnings when using buffer tracer Jun 1, 2023
@alehed alehed changed the title Fix glib critical warnings when using buffer tracer Fix critical warnings when using buffer tracer Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alehed