Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Privacy Manifest for iOS #437

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Privacy Manifest for iOS #437

wants to merge 3 commits into from

Conversation

KaustubhKulkarni2202
Copy link

  • Adds a privacy manifest.
  • Updates Package.swift to include the privacy manifest
  • Updates podspec to include the privacy manifest

@ZevEisenberg
Copy link
Collaborator

Thanks! Maybe this will be the push I need to get our CI working again. I have an old WIP PR at #433 that I might dust off.

@ZevEisenberg ZevEisenberg mentioned this pull request Mar 26, 2024
Open
Kaustubh Kulkarni added 2 commits March 28, 2024 12:53
ZevEisenberg
ZevEisenberg reviewed Mar 28, 2024
View reviewed changes
Package.swift
@@ -35,6 +37,7 @@ let package = Package(
],
resources: [
.process("Resources"),
.copy("PrivacyInfo.xcprivacy"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed in the test target?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

Package.swift
),
exclude: ["Info.plist"],
resources: [
.copy("PrivacyInfo.xcprivacy"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why copy instead of process?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we are not applying a platform-specific rule to the resource we need copy of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapitoshka438 kapitoshka438 kapitoshka438 left review comments

@ZevEisenberg ZevEisenberg ZevEisenberg left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KaustubhKulkarni2202 @ZevEisenberg @kapitoshka438