Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate hairlines API #24

Open
heyltsjay opened this issue Sep 28, 2020 · 1 comment
Open

Investigate hairlines API #24

heyltsjay opened this issue Sep 28, 2020 · 1 comment

Comments

@heyltsjay
Copy link
Contributor

I have a suspicion that the functionality for:

  • hairlines(after
  • hairlines(around
  • hairlines(between

will not behave as expected in the case that some cell in the middle of the group is hidden.

Hairlines(between: [A, B, C, D]) is deconstructed into
[A, B], [B, C], [C, D]

If view B is hidden, the first and second hairline binding will drop its visibility, resulting in no hairline between A and C.

@heyltsjay
Copy link
Contributor Author

Another example would be hairlines(around
The implementation assumes that the first view is visible, and applies a hairline above and below it.
But the desired functionality is that whatever the first visible view is gets both hairlines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant