Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.1 the published RiskifiedBeaconXCFramework.podspec should not contain EXCLUDED_ARCHS #18

Open
adellibovi opened this issue Jun 3, 2022 · 3 comments

Comments

@adellibovi
Copy link

Hello, while the podspec included in this repo is correct, the one published is different and it includes:

  "user_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  },
  "pod_target_xcconfig": {
    "EXCLUDED_ARCHS[sdk=iphonesimulator*]": "i386"
  }

This is not required since the frameworks do not contain anymore that slices, and it can create issues with Cocoapods when having other xcframework with similar (but different values)

@adellibovi
Copy link
Author

cc @mooseriskified

@adellibovi adellibovi changed the title 1.3.1 the published RiskifiedBeaconXCFramework.podspec contains EXCLUDED_ARCHS 1.3.1 the published RiskifiedBeaconXCFramework.podspec should not contain EXCLUDED_ARCHS Jun 3, 2022
@mooseriskified
Copy link
Contributor

@adellibovi We were running into an issue with pod release "CocoaPods/CocoaPods#10523"

Could you elaborate on the issue you are running into?

@crsantos
Copy link

crsantos commented Aug 26, 2022

@mooseriskified

As @adellibovi referred, you don't include the slice i386 in the xcframework anymore, it's 32bits, so it's not a problem

This clashes with other libs that have exclusions, where cocoapods state that:

[!] Can’t merge user_target_xcconfig for pod targets: [“RiskifiedBeaconXCFramework”, “AnotherRandomLib”]. Singular build setting EXCLUDED_ARCHS[sdk=iphonesimulator*] has different values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants