Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecoregions 1- 4 are NOT symbolized at all or correctly (use EPAs legends to get colors and labels). #558

Open
3 of 20 tasks
joewheaton opened this issue Apr 13, 2023 · 13 comments
Assignees
Labels
🌐 Viewer Arc Our map viewer plugin for ArcGIS 🌐 Viewer QGIS Our map viewer plugin for QGIS 🌐 Viewer Web Our web map viewer inside the data exchange pkg:RS_Context

Comments

@joewheaton
Copy link
Contributor

joewheaton commented Apr 13, 2023

See https://youtu.be/Ze60sYAgu9s?t=2133

Fix with Labels (using Karla) and Symbology for

  • Level 1
  • Level 2
  • Level 3
  • Level 4

To-Do

  • Start new branch with descriptive name for these changes (e.g. RS_Context 2.0)
  • Make necessary edits to business logic and commit to new branch
  • Author *.qml for QRAVE of layer(s) and test in QRAVE and commit
  • Produce screen shot of each qml layer to provide in commit or later pull request for reviewer (include legend). Also, provide warehouse link to riverscape project you did testing on (use same project(s) for testing ArcRAVE and WebRAVE)
  • Make pull request for just QRAVE changes. Choose appropriate reviewer(s)
  • Author *.lyr for ArcRAVE of layer(s) and test in ArcRAVE and commit
  • Make pull request for just ArcRAVE changes. Choose appropriate reviewer(s)
  • Produce screen shot of each lyr file to provide in commit or later pull request for reviewer (include legend)
  • Author symbology files for WebRAVE and provide link in commit to webRAVE of project it can be tested on
  • Make pull request for just WebRAVE changes. Choose appropriate reviewer(s)
  • Author or Update any project type documentation
  • Update or Add Project Views to Reflect Changes (if necc.)
  • After pull request(s) merged, test in updated qRAVE
  • After pull request(s) merged, test in updated ArcRAVE
  • After pull request(s) merged, test in updated WebRAVE
  • Delete local branch(es) you used for your pull request(s)
@wally-mac
Copy link

@leallysmith I'm assigning this to you. Please delegate as needed. Thanks.

@Cashe93 Cashe93 assigned Cashe93 and unassigned leallysmith Apr 13, 2023
@Cashe93
Copy link
Collaborator

Cashe93 commented Apr 13, 2023

@joewheaton, The issue with the Ecoregion 3 layer is that the attribute values from the RSContext layer are inconsistent with the EPA layer (luckily, this only appears to be an issue with L3). The attribute the symbology is referencing for L3 should start with a three-decimal code (e.g. 2.9.3), but for whatever reason, the level 3 ecoregion attribute that is within RSContext projects is just a two-digit integer.

image

The only solution I can think of is to download the full North American layer and manually curate the symbology using an attribute that only references the name and not the code. This wouldn't take too much time if you were ok with an approximate similarity to the EPA symbology. If you wanted the symbology to match the EPAs exactly, that will take quite a bit longer given the number of classes. Thoughts? I'm also open to any ideas other @Riverscapes/riverscape-project-curators might have to get the current symbology to work.

@joewheaton
Copy link
Contributor Author

Thank you so much @Cashe93 for the explanation. @philipbaileynar what do you think. Add these to the National dataset?

@jtgilbert
Copy link
Contributor

This is already pulled from the National dataset. I think it's just a data consistency issue.

@joewheaton
Copy link
Contributor Author

I'm not following on your suggestion? We need to mitigate against know inconsistency if we can.

@shelbysawyer
Copy link
Collaborator

I was working in this RS Context project in QRV and noticed that Level 1, 2, and 4 Ecoregions show up and are symbolized, but Level 3 Ecoregions do not. It also looks like the labels are displaying twice for Level 1 Ecoregions:

rsc

@Cashe93
Copy link
Collaborator

Cashe93 commented Jul 20, 2023

Just circling back on this. @shelbysawyer thanks for the notes; the level 3 ecoregion issue has been discussed above. It looks like the redundant labels are just a result of the layer being a multipart feature; each feature is labeled once but there are multiple features with the same name.

@joewheaton and @jtgilbert how would you like me to proceed with the level 3 symbology? Also, level 4 ecoregions have nearly 1000 categories; symbology has been applied for Q and Arc but to manually do this in Mapbox is going to be pretty tedious and time-consuming. Do you think this is worth muscling through, or should we explore alternative options? @MattReimer, any ideas on how to streamline this?

@MattReimer
Copy link
Member

As for the duplicated label you're right that it's probably due to the multipart feature. There's no hard solution to this that I'm aware of but you might be able to dial that in (in the web anyway) using features like symbol spacing:

As for the 1000 category feature:

If you symbolize one category the way you like it then it might be possible to write a python script to convert from the qml. We do something similar for the EVT rasters HERE but the idea is the same. You just need to output a JSON file instead of a CSV file.

@CHafen
Copy link
Contributor

CHafen commented Sep 14, 2023

Just bring this back up @Cashe93 @jtgilbert @joewheaton as level 3 ecoregions are not symbolized yet for web.

@joewheaton and @jtgilbert how would you like me to proceed with the level 3 symbology? Also, level 4 ecoregions have nearly 1000 categories; symbology has been applied for Q and Arc but to manually do this in Mapbox is going to be pretty tedious and time-consuming. Do you think this is worth muscling through, or should we explore alternative options? @MattReimer, any ideas on how to streamline this?

@joewheaton
Copy link
Contributor Author

I can't remember what the problem was? @Cashe93 do you? I think we figured out why it was not displaying properly, but maybe not a solution?

@joewheaton
Copy link
Contributor Author

Also @CHafen did you see the new webRV stuff that @MattReimer added for vector layer editing in browser? It is really nice for testing and customizing what you want.

@Cashe93
Copy link
Collaborator

Cashe93 commented Sep 15, 2023

@joewheaton, yeah we figured out why it wasn't displaying properly, but still haven't pinned down a solution. See here (or above) for the comment laying out the issue.

@joewheaton
Copy link
Contributor Author

joewheaton commented Sep 18, 2023

@CHafen, can you please schedule a time to meet with @Cashe93 and maybe he can walk you through the manual fix proposed. If necessary, bring in @Jdgilby if any additional cleaning of that dataset is needed.

If this proves unfruitful, then lets just remove the Level III from Business Logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 Viewer Arc Our map viewer plugin for ArcGIS 🌐 Viewer QGIS Our map viewer plugin for QGIS 🌐 Viewer Web Our web map viewer inside the data exchange pkg:RS_Context
Projects
None yet
Development

No branches or pull requests

8 participants