Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbology for Condition Layers in RCAT Project Type #650

Open
5 of 16 tasks
jtgilbert opened this issue Aug 22, 2023 · 23 comments
Open
5 of 16 tasks

Symbology for Condition Layers in RCAT Project Type #650

jtgilbert opened this issue Aug 22, 2023 · 23 comments
Assignees
Labels
pkg:RCAT symbology Use for new symbology work

Comments

@jtgilbert
Copy link
Contributor

jtgilbert commented Aug 22, 2023

Specification

Project Type: RCAT
Layer(s): both vwReaches and vwIgos
Layer Name: Riparian Condition

Type(s) - Vector

Description and/or Explanation of Need

I think we should update the color scheme for condition (to make it distinct from other layers that use the red to green color scheme) to match the old version of the tool.

Example(s) of Inspiration

Example here (don't worry about the old confined categories)


To-Do

Instructions for tasks:

  1. delete those tasks not needed;
  2. check off tasks as you complete them;
  3. do not close issue until all tasks completed
  4. reference this issue in all commits (e.g. with #33 notation where 33 is issue number)
  • Start new branch with descriptive name for these changes (e.g. curation_Veg_RCAT)
  • Make necessary edits to business logic and commit to new branch
  • Author *.qml for QRAVE of layer(s) and test in QRAVE and commit
  • Produce screen shot of each qml layer to provide in commit or later pull request for reviewer (include legend). Also, provide warehouse link to riverscape project you did testing on (use same project(s) for testing ArcRAVE and WebRAVE)
  • Make pull request for just QRAVE changes. Choose appropriate reviewer(s)
  • Author *.lyr for ArcRAVE of layer(s) and test in ArcRAVE and commit
  • Make pull request for just ArcRAVE changes. Choose appropriate reviewer(s)
  • Produce screen shot of each lyr file to provide in commit or later pull request for reviewer (include legend)
  • Author symbology files for WebRAVE and provide link in commit to webRAVE of project it can be tested on
  • Make pull request for just WebRAVE changes. Choose appropriate reviewer(s)
  • Author or Update any project type documentation
  • Update or Add Project Views to Reflect Changes (if necc.)
  • After pull request(s) merged, test in updated qRAVE
  • After pull request(s) merged, test in updated ArcRAVE
  • After pull request(s) merged, test in updated WebRAVE
  • Delete local branch(es) you used for your pull request(s)
@jtgilbert jtgilbert added symbology Use for new symbology work pkg:RCAT labels Aug 22, 2023
@jtgilbert
Copy link
Contributor Author

Instead of a new issue I'm going to tag on this one @emilySarge .
We also need to add intermediates related to riparian conversions. The vwReaches and vwIgos layers have a field ConversionType that should have symbology curated. My preference would be to use this color scheme, but with different lightness/darknesses of the colors based on the level of conversion (%). I think it would also be useful to UPDATE the conversion raster to use this same color scheme.
Finally, business logic will need updated to included these intermediates.
This is kind of a lot, so reach out when/if you need some guidance or have questions.

@emilySarge
Copy link
Contributor

emilySarge commented Aug 24, 2023 via email

@emilySarge
Copy link
Contributor

@jtgilbert Just to be clear, this is the color change you're aiming for?
image

@jtgilbert
Copy link
Contributor Author

Yes @emilySarge, looking good.

@emilySarge
Copy link
Contributor

IGO sizing options:
image

@emilySarge
Copy link
Contributor

Hey @jtgilbert, did you see the 'RCAT Condition Symbology Updates' pull request that I made on 12 Sept? It has the new esri files and edits to the qgis files.

@emilySarge
Copy link
Contributor

Also @jtgilbert, for the Mapbox symbology, do I need to use HSL for the colors, or can I use HEX values?

@MattReimer
Copy link
Member

@emilySarge you can use hex values too or rgb if that works better for you:

  • rgb(0,255,0)
  • #00FF00

@jtgilbert
Copy link
Contributor Author

@emilySarge I'm not seeing any open PRs. I may have already merged it?

@joewheaton
Copy link
Contributor

joewheaton commented Nov 14, 2023

@jtgilbert, @emilySarge and @dominique-shore. This has become a high priority to get the IGO Riparian Condition and and Reach Riparian Condition working in Web Rave. I have assigned this to @dominique-shore for now. It looks like @emilySarge might have already done the work here, but we never got any resolution on the pull-requests. If those commits are on a branch that someone can find, lets review them and action them.

See: https://riverscapes.freshdesk.com/a/tickets/18 and https://riverscapes.freshdesk.com/a/tickets/26

@jtgilbert please re-assign as appropriate.

@dominique-shore
Copy link
Contributor

dominique-shore commented Nov 15, 2023

@jtgilbert committed on Sept 11 (233fe41) to change the vwIGOs from "condition_igo" to "condition_igo_v2" and vwReaches from "condition" to "condition_v2". Those .qml files are present in symbology/qgis/RCAT, but not sybmology/web/RCAT. The new .qml files just need to be added to the web folder.

HOWEVER - When I add the RCAT .xml files in QRAVE, and add the vwIGOs, nothing appears and there is no Layer Metadata. I'm not sure why that is happening. The data exists because if I add the rcat.gpkg, I can add the vwIgos layer and apply the condition_igo_v2.qml, and it looks good.

@dominique-shore
Copy link
Contributor

The FPAccess.qml file is also missing in sybmology/web/RCAT, so intermediates/floodplain accessibility is loading without symbology in WebRAVE

@jtgilbert
Copy link
Contributor Author

@emilySarge will you have time in the next little bit to update web symbology, or should we get someone else on it?

@jtgilbert
Copy link
Contributor Author

@dominique-shore HOWEVER - When I add the RCAT .xml files in QRAVE, and add the vwIGOs, nothing appears and there is no Layer Metadata. I'm not sure why that is happening. The data exists because if I add the rcat.gpkg, I can add the vwIgos layer and apply the condition_igo_v2.qml, and it looks good.
I think this is a viewer bug we need to file. I've noticed this as well, it won't let me add line network outputs and igo outputs at the same time I have to remove the whole outputs folder then add one or the other.

@dominique-shore
Copy link
Contributor

Yep - I'm seeing the same thing, now. I can look at one or the other, but not both. @jtgilbert Do you want to file the QRAVE issue or should I?

@jtgilbert
Copy link
Contributor Author

Yep - I'm seeing the same thing, now. I can look at one or the other, but not both. @jtgilbert Do you want to file the QRAVE issue or should I?

Go for it!

@dominique-shore
Copy link
Contributor

Go for it!

Riverscapes/QRAVEPlugin#95

@dominique-shore
Copy link
Contributor

dominique-shore commented Dec 11, 2023

@jtgilbert I'm working on symbology for the field ConversionType, and came across a couple things.

  1. In the layer vwReaches, the value Conifer - Significant (>50%). It's present in 'vwIgos'
  2. Not sure what Grass/Shrubland vs. From Grass/Shrubland. I would assume that Grass/Shrubland is supposed to change to Grass&Shrubland, but I'm not sure where from grass/shrubland falls, as many of types are probably conversion from grass/shrubland. Would an area that was changed from shrubland to a development show up as 'From Grass/Shrubland' or 'Development?'
  3. In the 'vwIGOs' layer, there is only "Multiple Dominate-Moderate"

image

@jtgilbert
Copy link
Contributor Author

@dominique-shore there's a way to add classes for which there's not values in the dataset you're using. I can show you tomorrow if you have any time to meet for a min.

@dominique-shore
Copy link
Contributor

@jtgilbert Here are the labels and colors I have for . Some are based off the colors you selected and a few I made up, as those classes didn't exist in the past version of RCAT. Ones I created are in italic. Let me know what you think.

image

@jtgilbert
Copy link
Contributor Author

@dominique-shore Maybe try making the FROM ones just really light (or really dark) shades of their counterparts. Right now I could see confusing from conifer and no change and from and grass and to grass.

@dominique-shore
Copy link
Contributor

Sure - those are close. I'll make them lighter versions.

@dominique-shore
Copy link
Contributor

@jtgilbert After testing the ConditionCode symbology in QRAVE, the vector files both look good, but the raster file does not. The Condition raster displays with singleband gray symbology, like a hillshade. I check the spelling of the raster .qml in the business logic & that looks fine.

I'm just having issues with that .qml in general. I changed the colors to match the vector files, and it looked good. However, whenever I just use 'load style' to add the .qml to a condition raster, it looks completely different, and the colors are wrong. The colors and classification look fine in the legend & under properties -> symbology, but do not look right on the map. I'm stumped.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:RCAT symbology Use for new symbology work
Projects
None yet
Development

No branches or pull requests

5 participants