River Area Polygons not clipped to Project Boundary

[joewheaton]

From #743. @philipbaileynar and I discussed this. It has caused us problems in VBET and I think we should clip it. The old excuse of it has errors seems like it was an easy fix for Ownership. Lets fix it here too.

See https://youtu.be/Ze60sYAgu9s?t=1092

[jtgilbert]

I can add a clip to this, but this layer isn't even in VBET any more, so it doesn't cause any problems.

[philipbaileynar]

The fix for ownership was a human process! We obviously can't replicate this for downloaded NHD data.

We need to tread carefully here. The value of riverscapes context diminishes to zero if it becomes unreliable. If the flow area polygons contain errors then the intersection will fail and the final project will look fine but will actually be missing features. All downstream projects are garbage!

This is why the reliable alternative was adopted whereby we just include the entire feature if it touches the HUC. It is annoying, but it is 100% reliable.

Perhaps we adopt a hybrid approach: Attempt the intersection, but if it fails then we simply log the error and include the entire feature.

[joewheaton]

In scrum, we decided to update the business logic so that it points at the other, segmented version of this that is what ChannelArea uses, and just leaving this layer in there, but not displaying it.