You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Love the scaffolder actions yall have published so far. After a bit of usage in our own templates, I would like to suggest that the parse action does not fail the step if the file set in input.path does not exist. In cases where the file is not found, it should default to what the user sets.
Possible Implementation
Update roadiehq:utils:fs:parse to accept a new, optional input called default. When not provided, it will continue to fail the pipeline. If provided, when the file is not found it will just return the default as output.content.
Context
In many cases for our software templates, it is not guaranteed that the file will exist, but it is guaranteed that the file we are merging it with will. Rather than adding an extra step to ensure the file exists before trying to parse then merge it, this could simplify the software template pipeline if we are just allowed to set a default value.
Let me know if you need more context. If/when we agree on an implementation, I also wouldn't mind throwing up a PR for this.
The text was updated successfully, but these errors were encountered:
Feature Suggestion
Love the scaffolder actions yall have published so far. After a bit of usage in our own templates, I would like to suggest that the parse action does not fail the step if the file set in
input.path
does not exist. In cases where the file is not found, it should default to what the user sets.Possible Implementation
Update
roadiehq:utils:fs:parse
to accept a new, optional input calleddefault
. When not provided, it will continue to fail the pipeline. If provided, when the file is not found it will just return the default asoutput.content
.Context
In many cases for our software templates, it is not guaranteed that the file will exist, but it is guaranteed that the file we are merging it with will. Rather than adding an extra step to ensure the file exists before trying to parse then merge it, this could simplify the software template pipeline if we are just allowed to set a default value.
Let me know if you need more context. If/when we agree on an implementation, I also wouldn't mind throwing up a PR for this.
The text was updated successfully, but these errors were encountered: