Fix output duplication incorrect parameter#4
Merged
RobbyV2 merged 2 commits intoRobbyV2:mainfrom Apr 7, 2026
Merged
Conversation
|
Review these changes at https://app.gitnotebooks.com/RobbyV2/dxgi-capture-rs/pull/4 |
RobbyV2
approved these changes
Apr 7, 2026
Owner
RobbyV2
left a comment
RobbyV2
left a comment
There was a problem hiding this comment.
Code looks good - the retry logic with no feature levels is the right fix for hardware compatibility. Thanks!
RobbyV2
pushed a commit
that referenced
this pull request
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
DXGIManager::acquire_output_duplication()method retry theoutput1.DuplicateOutput(&d3d11_device)function call by recallingd3d11_create_device()with no feature levels (D3D_FEATURE_LEVEL), instead of the currently hardcodedD3D_FEATURE_LEVEL_9_1.Fixes Output duplication error: "The parameter is incorrect."