Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

robolink.py type-hinting missing for setAsJointTarget and setAsCartesianTarget methods #158

Open
sjohnson-FLL opened this issue Jun 24, 2024 · 1 comment
Assignees

Comments

@sjohnson-FLL
Copy link

In robolink.py, the Item class has setAsCartesianTarget and setAsJointTarget methods. In both cases, these methods conclude with return self, which would return an instance of the Item class. While other methods around it have type-hinting for the returned values, this method is not type-hinted for 'Item'.

To fix, either:

  1. Add ->'Item' type-hinting to the return values of those methods.
  2. Remove return self from those methods. (Breaks backwards-compatibility, but this return behavior was never documented in the first place anyway.)
@RoboDK
Copy link
Owner

RoboDK commented Jun 25, 2024

Thank you for your feedback. We fixed this with your suggested option 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants