Merge pull request #68 from RoboFinSystems/chore/xbrlkit-footer-application

chore(footer): list xbrlkit under Applications

Author: jfrench9

ui-components/layout/LandingFooter.tsx

@@ -39,8 +39,9 @@ const headingClass =
 
 /**
  * The shared marketing-site footer for all three apps. The brand column, social
- * row, the Applications cross-links, the Company column and copyright are
- * derived from CURRENT_APP + APP_CONFIGS so each app reskins automatically;
+ * row, the Applications cross-links (the three apps, then xbrlkit), the Company
+ * column and copyright are derived from CURRENT_APP + APP_CONFIGS so each app
+ * reskins automatically;
  * only the tagline and Product links vary and are passed in. Contact stays
  * per-app via the `contactModal` prop.
  */
@@ -187,6 +188,22 @@ export function LandingFooter({
                   </li>
                 )
               })}
+              <li>
+                {/* xbrlkit, the free report viewer with its MCP server, is an
+                    application in its own right, listed after the three apps. It
+                    is a standalone site on its own domain, not an app config, so it
+                    is always an external link (absolute URL, new tab) from every
+                    app. Named the way the site names itself: "viewer" left its
+                    wordmark when /mcp made it a second function. */}
+                <Link
+                  href="https://xbrlkit.com"
+                  target="_blank"
+                  rel="noopener noreferrer"
+                  className={linkClass}
+                >
+                  xbrlkit
+                </Link>
+              </li>
             </ul>
           </div>
 
@@ -202,20 +219,6 @@ export function LandingFooter({
                   Research
                 </Link>
               </li>
-              <li>
-                {/* xbrlkit — the report viewer and its MCP connect page, a standalone
-                    public site on its own domain, always an external link (absolute
-                    URL, new tab) from every app. Named the way the site names itself:
-                    "viewer" left its wordmark when /mcp made it a second function. */}
-                <Link
-                  href="https://xbrlkit.com"
-                  target="_blank"
-                  rel="noopener noreferrer"
-                  className={linkClass}
-                >
-                  xbrlkit
-                </Link>
-              </li>
               <li>
                 <Link
                   href={resolvedBlogHref}

ui-components/layout/__tests__/LandingFooter.test.tsx

@@ -1,4 +1,4 @@
-import { render, screen } from '@testing-library/react'
+import { render, screen, within } from '@testing-library/react'
 import { afterEach, describe, expect, it, vi } from 'vitest'
 import type { LandingFooterProps } from '../LandingFooter'
 
@@ -62,3 +62,41 @@ describe('LandingFooter company links', () => {
     expect(link('Blog')).not.toHaveAttribute('target')
   })
 })
+
+describe('LandingFooter applications', () => {
+  afterEach(() => {
+    vi.doUnmock('../../../auth-core/config')
+  })
+
+  // A footer column is the list that follows its heading.
+  const column = (heading: string) =>
+    screen.getByRole('heading', { name: heading })
+      .nextElementSibling as HTMLElement
+
+  it('lists xbrlkit after the three apps, as an external link', async () => {
+    await renderAs('robosystems')
+    const apps = within(column('Applications'))
+      .getAllByRole('link')
+      .map((a) => a.textContent)
+    expect(apps).toEqual([
+      'RoboSystems',
+      'RoboLedger',
+      'RoboInvestor',
+      'xbrlkit',
+    ])
+
+    const xbrlkit = within(column('Applications')).getByRole('link', {
+      name: 'xbrlkit',
+    })
+    expect(xbrlkit).toHaveAttribute('href', 'https://xbrlkit.com')
+    expect(xbrlkit).toHaveAttribute('target', '_blank')
+    expect(xbrlkit).toHaveAttribute('rel', 'noopener noreferrer')
+  })
+
+  it('no longer lists xbrlkit under Company', async () => {
+    await renderAs('roboledger')
+    expect(
+      within(column('Company')).queryByRole('link', { name: 'xbrlkit' })
+    ).toBeNull()
+  })
+})