Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstream patches #31

Closed
Tobias-Fischer opened this issue Jul 20, 2021 · 4 comments
Closed

Upstream patches #31

Tobias-Fischer opened this issue Jul 20, 2021 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Tobias-Fischer
Copy link
Contributor

We should try and get as many patches upstream as possible.
@Tobias-Fischer Tobias-Fischer added good first issue Good for newcomers help wanted Extra attention is needed labels Jul 20, 2021
@traversaro
Copy link
Member

Once merged and released ros2/rviz#817 should permit to remove the patch https://github.com/RoboStack/ros-galactic/blob/main/patch/ros-galactic-rviz-assimp-vendor.patch

@traversaro
Copy link
Member

ros-galactic-osrf-testing-tools-cpp.patch proposed upstream in osrf/osrf_testing_tools_cpp#68 .

@traversaro
Copy link
Member

Once merged and released ros2/rviz#817 should permit to remove the patch https://github.com/RoboStack/ros-galactic/blob/main/patch/ros-galactic-rviz-assimp-vendor.patch

Actually we probably need to wait for a galactic backport if anyone ever works on that: ros2/rviz#826 .

@traversaro traversaro mentioned this issue Mar 26, 2022
Merged
@traversaro traversaro mentioned this issue Feb 10, 2024
Open
@traversaro
Copy link
Member

We do not support galactic anymore, so we need to upstream ros humble and ros jazzy patches now, see RoboStack/ros-humble#138 and RoboStack/robostack.github.io#16 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@traversaro @Tobias-Fischer