From 6ed8e3b05e91dd178c5ab7bf7cf9949a385ec5e0 Mon Sep 17 00:00:00 2001 From: Ben Congram <54913267+ben-congram@users.noreply.github.com> Date: Tue, 11 Jul 2023 10:53:31 -0400 Subject: [PATCH 1/2] fix: return empty response if node info not available --- rosapi/scripts/rosapi_node | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rosapi/scripts/rosapi_node b/rosapi/scripts/rosapi_node index af478ee52..ae1d7b56f 100755 --- a/rosapi/scripts/rosapi_node +++ b/rosapi/scripts/rosapi_node @@ -172,7 +172,7 @@ class Rosapi(Node): response.subscribing, response.publishing, response.services, - ) = proxy.get_node_info(request.node) + ) = proxy.get_node_info(request.node) or ([], [], []) return response def get_action_servers(self, request, response): From ac3d611745706065fbf614af99760f1ef9543675 Mon Sep 17 00:00:00 2001 From: Ben Congram <54913267+ben-congram@users.noreply.github.com> Date: Tue, 11 Jul 2023 11:02:24 -0400 Subject: [PATCH 2/2] style: lint --- rosapi/scripts/rosapi_node | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/rosapi/scripts/rosapi_node b/rosapi/scripts/rosapi_node index ae1d7b56f..5a23cb13a 100755 --- a/rosapi/scripts/rosapi_node +++ b/rosapi/scripts/rosapi_node @@ -168,11 +168,9 @@ class Rosapi(Node): def get_node_details(self, request, response): """Called by the rosapi/Nodes service. Returns a node description""" - ( - response.subscribing, - response.publishing, - response.services, - ) = proxy.get_node_info(request.node) or ([], [], []) + (response.subscribing, response.publishing, response.services,) = proxy.get_node_info( + request.node + ) or ([], [], []) return response def get_action_servers(self, request, response):