Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow install of Ros2ForUnity asset in sub-directory #86

Open
RobertoRoos opened this issue Sep 15, 2023 · 2 comments
Open

Allow install of Ros2ForUnity asset in sub-directory #86

RobertoRoos opened this issue Sep 15, 2023 · 2 comments

Comments

@RobertoRoos
Copy link

Is your feature request related to a problem? Please describe.

I would like to install the asset in a subdirectory, e.g. Assets/Externa/Ros2ForUnity. This way I can organize not self-made assets in one place.

Describe the solution you'd like

Currently this would result in a runtime error, because the accompanying xml files are then not found. The asset path is hardcoded.

I know little of Unity, but I imagine there is some path tools to provide the current script path, from which other resources could be located. That seems more robust.

Describe alternatives you've considered
NaN

Additional context
NaN

@RobertoRoos
Copy link
Author

Even better: I guess this plugin should be a Package, instead of a folder under Assets.

I experimented with this one: https://github.com/RobertoRoos/ROS2-for-Unity-Package
I committed the v1.3.0 Windows standalone build, with a package.json and some other changes to hard-coded paths. You can now simply refer to this Git repository with the Unity package manager and it should work.

Of course Git is not really suited for binary releases like this, but the archives uploaded here could be for a package instead, making them more modular compared to a set of assets. The Unity package manager can also install from a downloaded archive.

Thoughts?

@RobertoRoos
Copy link
Author

I made a new branch on my fork for packaging: https://github.com/RobertoRoos/ros2-for-unity/tree/feature/package

This version uses paths that work for a package directory and contains the necessary json and asmdef files.
I tried to adapt the build scripts such that the procedure is the same, but I'm not sure they work as they should.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant